Skip to content

Leaks needs to be solved before release #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neslihanturan opened this issue Mar 26, 2018 · 10 comments
Closed

Leaks needs to be solved before release #1368

neslihanturan opened this issue Mar 26, 2018 · 10 comments

Comments

@neslihanturan
Copy link
Collaborator

neslihanturan commented Mar 26, 2018

Summary:

Here are leak reports needs to be solved before release (means this week)

Steps to reproduce:

Play with app, in general.

Add System logs:

leaks

This issue can be solved by several people. Please use comments efficiently to assign it yourselves by using letters (A/B/C/D/E/F).

Besides, this issue needs to be done in a week so help is appreciated :)

@yashshah7197
Copy link
Contributor

I'll kick things off by taking up the the 'A' leak. I can try to fix all of them too if that's okay. 👍 @nicolas-raoul @neslihanturan

@neslihanturan
Copy link
Collaborator Author

Firstly you can start with 'A', since this issue is urgent and requires parallel working. If you are done with 'A' don't hesitate to get another one, after you wrote comment here @yashshah7197

@misaochan
Copy link
Member

Thanks for volunteering to do "A", @yashshah7197 . :) If anyone else would like to take the others, please feel free to mention it here.

@yashshah7197
Copy link
Contributor

@neslihanturan can you tell me how I could reproduce these leaks? LeakCanary doesn't seem to be detecting anything for me yet.

On a side note, sorry for the late updates. I'm down with a bit of fever and cough so can't really work on anything properly right now. 🙈

@neslihanturan
Copy link
Collaborator Author

neslihanturan commented Mar 28, 2018

@yashshah7197 just playing with app, I don't know either. I hope you get well soon.

@neslihanturan
Copy link
Collaborator Author

I am working on B and C

@neslihanturan
Copy link
Collaborator Author

@yashshah7197 this issues needs to be done today, will you be able to make it up? If not I will give a try.

@neslihanturan
Copy link
Collaborator Author

I am on D,E,F

@neslihanturan
Copy link
Collaborator Author

It seems like E and F is something we can ignore: https://medium.com/@amitshekhar/android-memory-leaks-inputmethodmanager-solved-a6f2fe1d1348

@misaochan
Copy link
Member

Closing, we can create a new issue if there are further leaks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants