Skip to content

Fix nearby leaks, at least some ot them #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2018
Merged

Conversation

neslihanturan
Copy link
Collaborator

Description

Fixes #1368 , current leaks. Currently I could only reproduce C, it took too much time to be able to reproduce it. A and B is same, and It seems like E and F is something we can ignore: https://medium.com/@amitshekhar/android-memory-leaks-inputmethodmanager-solved-a6f2fe1d1348

Since we have already solved B (also A) and D, we should only have C

Tests performed

Manual testing, API level 19

@codecov-io
Copy link

Codecov Report

Merging #1390 into 2.7.x-release will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##           2.7.x-release   #1390      +/-   ##
================================================
- Coverage           3.32%   3.31%   -0.01%     
================================================
  Files                128     128              
  Lines               6804    6808       +4     
  Branches             667     668       +1     
================================================
  Hits                 226     226              
- Misses              6563    6567       +4     
  Partials              15      15
Impacted Files Coverage Δ
...rw/commons/upload/DetectUnwantedPicturesAsync.java 0% <0%> (ø) ⬆️
...ava/fr/free/nrw/commons/nearby/NearbyActivity.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/upload/ShareActivity.java 0% <0%> (ø) ⬆️
.../fr/free/nrw/commons/nearby/NearbyMapFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc294a...7b5c5ce. Read the comment docs.

@neslihanturan
Copy link
Collaborator Author

I am merging my own PR, since release is urgent.

@neslihanturan neslihanturan merged commit 09763f9 into 2.7.x-release Mar 30, 2018
@misaochan
Copy link
Member

Thanks @neslihanturan !

@misaochan misaochan deleted the fixNearbyLeaks branch March 30, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants