-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Upload fails often in 2.7 #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I actually also started to get failed uploads recently, when the new version was pushed to beta. Might be a coincidence though. Failed uploads were images I shared from the Android stock gallery. |
@nicolas-raoul Ah, interesting. Can you reproduce this reliably? What steps did you use to share the image - was it by going to the gallery, selecting the image, tapping "Share" and then selecting the Commons app? Where were the images stored - SD card, device, google photos etc? |
This seems very interesting. I looked at commit histories of possibly related classes but couldn't recognized a big change. Implement direct uploads for Nearby Map #1060 seems like the biggest change but I don't think it break something on regular upload. What do you think @misaochan , is this possible? Other than #1060 the reason can be a mistake made when merging or rebasing, or solving a leak. |
Nearby uploads did not require significant changes to regular uploads, I think it's very unlikely that the small changes made would have caused the failures. Also, the review re: failed uploads was made while production was still in 2.6 - if that user was in beta, I'd think he would have used beta feedback instead of quitting beta just so he could post a regular review. I will try and look at what might be causing this when I work on the upload overhaul. It would be very helpful to know where the images were stored etc. though. |
@misaochan We could |
Thanks for the suggestions, everyone! I'll create a separate issue for the logs. :) I got back to the user asking a few questions, hopefully that will help us with the failed uploads. @maskaravivek , I messaged you on Hangouts. |
@misaochan Yes the logs are very less and there's almost nothing useful in the logs. I just see this logline multiple times.
I remember seeing this log a few times in the app when logs upload fails for me. |
I tried to debug the issue [By uploading image from my google pixel emulator], it seems like there is an issue at the backend side, I am attaching the response xml which i am getting in the logs
As we can see from the xml, which says error code="abusefilter-disallowed, which hopefully states its a backend issue with some images. |
The error posted by @ashishkumar468 looks interesting. Am not sure if the user's upload failed with the same error. We are not logging server failure responses so there's no way to tell why it failed for the user. |
Just received permission from the user to repost his response to me. I think this will be very helpful:
|
It seems that the common denominator in both the above post's user and @nicolas-raoul 's reports is that they both used "Share" instead of uploading directly from the app. @nicolas-raoul do you recall if you "Share"d one or multiple photos when it happened to you? |
One by one.
I almost never use the multiple photo upload feature.
…On Mon, Jun 4, 2018 at 5:24 PM, Josephine Lim ***@***.***> wrote:
It seems that the common denominator in both the above post's user and
@nicolas-raoul <https://github.com/nicolas-raoul> 's reports is that they
both used "Share" instead of uploading directly from the app.
@nicolas-raoul <https://github.com/nicolas-raoul> do you recall if you
"Share"d one or multiple photos when it happened to you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1485 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGFBhChA70qBb6ZBP3xAFHQ1z1YpCSpks5t5O7WgaJpZM4TvNi0>
.
|
Thanks @nicolas-raoul ! Do you also remember where your photo was stored (SD card or device)? Do you ever share from Google Photos? |
I have had no luck with reproducing this bug on v2.7.1 (Android 7.0), despite experimenting with different ways of uploading via Share. I have tried:
All of the above uploads succeeded. Anyone have any idea how we can reproduce this? Otherwise I think it will be very difficult to solve this, at least not until we get Send Logs working in a more efficient manner so that people can send us useful logs of the failed uploads. #1489 |
I actually managed to reproduce this bug - by complete accident, while testing something else. The problem here is that this is the Play Store version 2.7.1 - I'm afraid to uninstall and build manually because then I might lose the reproduction. But I can't seem to get any sort of useful logs in logcat from it. Logcat is running, but our app's process appears to be... hidden? Even when filtering for our package, I only get logs that aren't actually generated by our package. It isn't that it's too much spam, but I sorted through the spam and our own logs are virtually nonexistent. Any idea what I'm doing wrong? |
Well, I can't reproduce this anymore. :/ Guess we have to hope that #1592 works. |
@misaochan this link can work to get rid of "no deugable process" alert: https://stackoverflow.com/questions/41033849/no-debuggable-processes-in-android-studio-when-connected-with-phone-which-runs-a |
I received a message on FB from a user who is experiencing this issue. She mentioned that the issue started a couple of months ago only, and about 99% of her uploads failed. She tried uninstalling and reinstalling the app, logging out and logging in again... none of that worked. So the issue may not be as simple as the auth token problem that we were assuming in #1592 . :/ She also says that while she normally uploads via "Share > Commons", her uploads from within the app itself fail as well. Based on her and @nicolas-raoul 's comments, it seems like this would have been caused by one of the changes we made in 2.7.0 (which was released early May). The problem is that that release was a HUGE one and we don't know what the trigger could've been. It could have been related to the 2FA auth change, it could have been related to direct Nearby uploads, or it could even have been caused by one of the small changes to ShareActivity (like searching through other pictures for coordinates, etc). Does anyone have any suggestions? I think that at the very least, along with the file system changes @neslihanturan is implementing, we need to implement a better feedback system for failed uploads. They should display to the user WHY they failed, in a manner that can be seen by the user, not just logs (which we cannot reliably obtain). |
We could get this FB user to do bisection, in order to find the exact commit that triggers the problem. |
I wouldn't mind doing the bisect (given a reasonable range to bisect, of course) if the FB user is ready to take APKs daily and try and test if it has issues or not. I think it would be a little tricky if there they couldn't consistently state a yes/no for "Whether the issue occurs to them in this APK?". BTW, I've actually faced this issue once before (last week when I wasn't poking around for #1654, think). I wasn't able to upload any images at all for some time and I had to re-install the app to make the issue go away. I tried to see if I could reproduce it now and I did see this happen again. I think a slightly wavery network might be behind this, I'm not sure though. My flow was something like,
|
Even a very rough bisect would be better than nothing, starting with the APK of the previously released version :-) That would rule out (or not) server-side changes. |
Thanks for volunteering, @sivaraam . :) Yes, I think the range would be between the 2.6.7 release and the 2.7.0 release. I will talk to the user about this once she gets back to me on the previous question that I asked her re: 2FA. @sivaraam what is your preferred method of communication, can I link her to your on-wiki talk page? |
How about communicating via the public mailing list? So that everybody can benefit from the insight or offer ideas. |
@misaochan Please have a look. |
How strange! The upload result says "Success". Does that image show up as "failed" for you, @VaishSiddharth ? |
@misaochan Are missing something, again? |
@misaochan I have noticed that if i click back button immediately after "Commons App has stopped" pops up then the upload fails otherwise the upload is successfull but the app crashes as you can see. |
@sivaraam I don't have the rights to create a custom visibility paste, and neither do most people who are posting their logs here. It would be extremely inconvenient to have to contact you or someone with those privileges every time we want to post any logs. Perhaps we could start another issue to brainstorm how we can handle this better? An alternative could be modifying the interceptor class to obfuscate parts of the logs. |
@VaishSiddharth Very interesting, thanks! Is it possible to get logs of the crash, and of the failed upload (same method as how you took logs of the successful one)? @sivaraam please feel free to create a custom paste for all of these logs if possible, thanks. And, umm, Vaish, could you please check if you can upload through the upload wizard in your browser - https://commons.m.wikimedia.org/wiki/Commons:Upload_Wizard ? Because you are uploading files with bad titles, it is possible that you were banned, lol. It is generally not a good idea to upload nonsensical stuff to the prod server. ;) Also, it seems our crash reporting system has ceased to work again. :/ |
@misaochan I uploaded an image successfully through upload wizard on browser. I think this means my account is not blocked. |
@misaochan Please have a look. |
Hmm, so this is the crash you are getting all the time?
I wonder how we can debug this. Our app package isn't mentioned in any part of the stack trace. :/ @maskaravivek @neslihanturan what do you think about this? @VaishSiddharth Good to hear that your account is fine. ;) Could I please trouble you for one final log - a failed upload all the way up to the part that you copied for your successful upload. This part is very important:
Also please don't be alarmed if we edit your post later, as we will be moving the logs to a custom visibility page. Thanks so much! |
@misaochan If i press the back button immediately after the app crash then the upload fails but if the back button is not pressed the upload is successful. I am not able to understand how can I share the logs of both failed and successful uploads at the same time. |
@VaishSiddharth Try this: Start the upload, let it crash, then press back button immediately, watch the upload status change to "failed", then copy all the logs? If you could email me your logs, once @maskaravivek gets a custom paste up, I can post them there. :) |
@misaochan Should I mail you the logs or paste them here? I dont have your email id. |
@misaochan That's the best thing we should be doing as a long term solution. |
@misaochan Just for the sake of completeness, I do not have permissions to create a paste with a custom policy. But as you now seem to be aware @maskaravivek does. |
@VaishSiddharth You could get a hint here |
Thanks for emailing me @VaishSiddharth @maskaravivek Could we get a custom visibility paste up on Phab, please? |
@misaochan I have added you to trusted contributors list on phab. Now you should be able to create a paste with custom visibility. https://phabricator.wikimedia.org/project/members/3104/ |
Thanks! Paste is at https://phabricator.wikimedia.org/P7465 and I have given @maskaravivek , @neslihanturan and @nicolas-raoul access. If anyone else needs it, please ask. |
From the logs it looks that the crash is happening because of the notifications issue @whym recently fixed.
@whym's fix was merged on August 19th. @VaishSiddharth I suspect that you are on API level >=26. Can you pull the latest upstream master and retry. The crash should no longer happen. |
@VaishSiddharth the fix is 6842420, in case you want to cherry-pick and try. :) |
@whym @maskaravivek Thanks I will try :) |
Hi, I am one of the people who reported failed uploads. Now it mostly works with 2.8.1 but I got 3 uploads blocked as "queued". I can't cancel nor retry them. |
Now I uploaded the same files separately and it worked. |
Additionally the item stays in the dropdown menu even after the image uploaded alright. |
Report from user on googlegroups
He says "Very often: Upload failed"
And has logs attached. Unfortunately I can't share them here without permission, but anyone who has signed the NDA that allows them to access our private group is welcome to check it there.
There are two issues here:
The logs don't provide any meaningful information. It is completely cluttered by system logs, etc. This has been the case for logs provided by everyone else as well. Is it at all possible for us to filter for our app's logs programmatically in the "send logs" feature?
The upload failing very often. I plan to ask him where he is uploading from (sd card, etc), and for screenshots if he can provide them. What other information do you guys think would be useful to solve the problem? @maskaravivek @psh @nicolas-raoul @neslihanturan
He isn't the only one with it - a recent Play Store review was from a user who encountered the same problem. So I would probably assign this issue a fairly high priority since this is our core functionality.
The text was updated successfully, but these errors were encountered: