Skip to content

ButterKnife is not used every where in the project #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ashishkumar468 opened this issue May 3, 2018 · 4 comments
Closed

ButterKnife is not used every where in the project #1491

ashishkumar468 opened this issue May 3, 2018 · 4 comments

Comments

@ashishkumar468
Copy link
Collaborator

ashishkumar468 commented May 3, 2018 •
edited by maskaravivek
Loading

Summary:

Some of the activities and fragments have used ButterKnife and some have not. It should ideally be used everywhere.

Steps to reproduce:

Lets compare AboutActivity and MediaDetailFragment

Add System logs:

NA

Expected behavior:

Ideally all of the activities and fragments should use it

Observed behavior:

As mentioned in the description, some of the activities and Fragment have used butterknife and some have not

Device and Android version:

NA

Commons app version:

NA
Screen-shots:

NA

Would you like to work on the issue?

Yes
@maskaravivek
Copy link
Member

Please feel free to take it up. IMO it would be great to start using everywhere in our codebase but we don't want to restrict new contributors if they are not familiar with Butterknife.

Refactoring code that doesn't use Butterknife would be more than welcome. :)

@ashishkumar468
Copy link
Collaborator Author

@maskaravivek Taking it up

ashishkumar468 pushed a commit to ashishkumar468/apps-android-commons that referenced this issue May 4, 2018
@ashishkumar0207
Implemented butterknife in MediaDetailFragment [issue commons-app#1491]
d305797
ashishkumar468 pushed a commit to ashishkumar468/apps-android-commons that referenced this issue May 4, 2018
@ashishkumar0207
Implemented butterknife in MediaDetailPagerFragment [[issue commons-a…
f7ad2cb 
…pp#1491]]
@ashishkumar468 ashishkumar468 mentioned this issue May 4, 2018
Merged
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue May 5, 2018
@ashishkumar468
post merge upstream master wip [[issue commons-app#1491]]
f9989ba
@ashishkumar468
Copy link
Collaborator Author

@maskaravivek Can you review this ?

neslihanturan pushed a commit that referenced this issue May 8, 2018
@ashishkumar468 @neslihanturan
Feature/switch to butterknife (#1494)
d960029 
* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue May 10, 2018
@ashishkumar468
Implemented butterknife in MultipleUploadListFragment [issue commons-…
2d1f166 
…app#1491]
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue May 10, 2018
@ashishkumar468
Implemented butterknife in ShareActivity [issue commons-app#1491]
8f76dd0
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue May 10, 2018
@ashishkumar468
Implemented butterknife in SimilarImageFragment [issue commons-app#1491]
66b275b
@ashishkumar468 ashishkumar468 mentioned this issue May 10, 2018
Merged
maskaravivek pushed a commit that referenced this issue May 18, 2018
@ashishkumar468
Feature/switch to butterknife (#1494)
cd212b7 
* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]
misaochan pushed a commit that referenced this issue May 31, 2018
@misaochan
Make P18 edits to corresponding wikidata entity on uploading from Nea…
4815e93 
…rby (#1495)

* Localisation updates from https://translatewiki.net.

* Integrate API for displaying featured images (#1456)

* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs

* Update pull_request_template.md (#1476)

* Update pull_request_template.md

* Remove Javadocs mention

* Added required/optional notes

* resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496)

* Open map of place where picture was taken (#1360)

* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added

* Add nearby tutorial (#1467)

* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style

* CONTRIBUTING: fix formatting of the gist of the guidelines (#1453)

* CONTRIBUTING: fix formatting of the gist of the guidelines

First level headings for a gist seems to be overkill.

So, replace first level headings with an ordered-list which
sounds more meaningful.

* CONTRIBUTING: specify clearly that 'blame' is a feature of "Git"

The contributing file specifies about the ability to know who wrote
something without the need of @author javadoc tags but incorrectly
attributes the feature to GitHub.

Correctly attribute the feature to where it belongs, Git, and specify
the name of the feature to help users easily take advantage of it.

* Feature/switch to butterknife (#1494)

* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]

* Localisation updates from https://translatewiki.net.

* Bug fix #1504 (#1506)

* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]

* Localisation updates from https://translatewiki.net.

* Fix security exception crash while accessing network location provider (#1498)

* Fix security exception crash while accessing network location provider

* Added java docs

* Localisation updates from https://translatewiki.net.

* Log P18 edits to wikidata corresponding wikidata entity on uploading a nearby image

* Added java docs

* Fix test build

* Refresh nearby

* Refresh nearby list on successful edit

* Java docs

* Make authenticated wikidata edits

* Updated toast message to show entity name that was edited
@domdomegg
Copy link
Member

#3530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maskaravivek @domdomegg @ashishkumar468