Add search Images from commons feature

[ujjwalagrawal17]

This is a child issue of #1221

Summary:

The users should be able to search images directly using name/description from commons.

Screen-shots:

Would you like to work on the issue?

Yes, I have started working on this issue. Will send a PR soon.

[maskaravivek]

@ujjwalagrawal17 As shown in the screenshot would you be adding this functionality in the featured image activity?

[ujjwalagrawal17]

@maskaravivek I am working on a separate search Activity which queries the data from servers. I am planning to open it from Featured Image Activity. Also, we can rename featured option to "explore" in the navigation drawer.

[maskaravivek]

IMO, you can very well use all the functionality of featured images activity as its totally generic but am not very sure about renaming it.

You can init a separate instance of the featured images activity naming it Explore in the hamburger menu.

Anyways if we have consensus on merging featured images with Explore then you can go ahead with it. :)

[nicolas-raoul]

Personally I am in favor of a single "Explore" item that shows featured images and a loop button to search.
The hamburger is already a bit crowded and might get more crowded with statistics, peer review, contests, etc.

[misaochan]

How about we have the search bar on top of Featured activity - when someone searches, they will initially be shown all the featured images that match their search. And when the results are displayed, we also have a "show non-featured images" button (similar to the "show more" button in other apps) where if they tap it, they can view the non-featured images as well for the same search term?

(Not sure if that's beyond the GSoC scope. If it exceeds scope, we can just have the search bar on top of Featured activity and have it just do one query for all images. Either way, I agree with Nicolas that we don't want two items on the nav bar, featured+browse should be consolidated into one activity IMO.)

[maskaravivek]

Yes, I agree that the hamburger is already too crowded. So having a single Explore sounds good to me (Y).

In addition to the search button, it would be great to have a filter button too. Right now the app shows all the featured images from Commons but there are further categories on Commons like Industry, History people etc.

https://commons.wikimedia.org/wiki/Commons:Featured_pictures

It would be great to have people filter and see featured images from a particular category.

[nicolas-raoul]

The wide majority of searches return zero featured pictures, because only 0.024% of pictures are featured.
If there was a "show non-featured images" button it would be necessary to click every at pretty much every single search.
So, I suggest showing all images for now, and, in the second part of the GSoC, showing the featured images matching the search at the beginning of the results. That is actually what is planned in the GSoC schedule :-)

[misaochan]

Oh! Yep, that sounds good to me @nicolas-raoul .

[ujjwalagrawal17]

@nicolas-raoul @neslihanturan We can discuss here that we should make a new Activity for exploring or refactor the code of CategoryImagesActivity (featuredActivity). @nicolas-raoul Can you catchup the discussion at #1561 .

[neslihanturan]

Let's continue here:
neslihanturan

We have to think about UIs. Because Featured images is not same with explore. You can explore ALL images. But when we add search icon top of featured images, it feels like user can only search in featured images. This is not the case.
@ujjwalagrawal17

ujjwalagrawal17

Yes @neslihanturan you are right. There are 2 solutions for this -

• We can change and refractor featured activity and rename it explore and below toolbar we can maybe mention that below images are featured using a textview maybe.
• Or create a seperate Explore activity and do it there.

misaochan

@neslihanturan Can that issue not be solved by having existing text in the search bar that says "Search all images in Commons"?

I would personally prefer Browse and Featured to be united in a single activity if possible, as they are highly related and it reduces cluttering. I believe we were discussing this at #1521

neslihanturan

I also meant we definitely should have them in same activity but maybe different tabs? Or your solution could also work. Under any case I think it is better to discuss on mockups. @ujjwalagrawal17 are you willing to create some mockups to find best solution? @nicolas-raoul I really wonder your opinion about this topic.

[ujjwalagrawal17]

I already made a few mock-ups.


I thought We can start with only featured images. Later on we can integrate picture of the day and customise it more.

Yes I will share some more mock ups for explore feature tomorrow!

[nicolas-raoul]

I believe this would be the best:

• One single item in the left menu called "Explore"
• Touching "Explore" show the featured images and a search icon in the corner
• Touching the search icon brings the search screen as implemented in this request
  In other words, like @ujjwalagrawal17 implemented looks great to me :-)

[neslihanturan]

Usage of tabs solved all unclarity for me. So for now I will merge @ujjwalagrawal17 's PR, then he can add other tabs on another PR.