Duplicated category suggestions

[nicolas-raoul]

Summary:

Categories suggestion contains duplicates

Steps to reproduce:

In the categories sggestions screen, search for "oculus go"

Commons app version:

2.7.1-debug-search_activity_mock~27e5e9c7

Screen-shots:

Would you like to work on the issue?

Not especially

[gupta1anubhav]

@nicolas-raoul I have figured out the issue and I am working on it.

[nicolas-raoul]

Could you please post what the Mediawiki API sends?
I suspect that the API does not send duplicate, and the app has a kind of bug that creates duplicates.
If it is the case, then we should fix the bug rather than add de-duplication.
Thanks! :-)

[gupta1anubhav]

Sorry @nicolas-raoul I am not able to find what Mediawiki API sends if you could help that would be great
In my opinion, duplicates could be because we are merging results from search categories and all categories on the same string.

[whym]

@gupta1anubhav To make sure, you might want to try temporarily inserting Log.d("API.searchCategories", categories.toString()); into somewhere around

apps-android-commons/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java

Line 335 in 7f02524

return categories;

(same goes for allCategories)

[nicolas-raoul]

Yes, some debug would be great to find out where the duplicates come from.
I understand that some duplicates may appear from time to time, but often it is the same long list of categories repeated exactly.

[nicolas-raoul]

Also happening in 2.8-release branch:

The same category is indeed added twice to the media on Commons: https://commons.wikimedia.org/w/index.php?title=File%3AHerbert_Von_Karajan_Platz.jpg&type=revision&diff=311621700&oldid=311621611

[nicolas-raoul]

Still happening in 2.9.0:

[ashishkumar468]

AFAIK, it was fixed in some previous releases, must have been brought back while introducing RX. Have added a fix, will raise a pr soon.