Skip to content

Setting text is truncated when space is not available #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sivaraam opened this issue Jun 27, 2018 · 1 comment
Closed

Setting text is truncated when space is not available #1670

sivaraam opened this issue Jun 27, 2018 · 1 comment

Comments

@sivaraam
Copy link
Member

Summary:
The settings text should not be truncated when space is not available as that leaves users with partial information which they cannot use to judge what the setting is actually for. This is especially a major issue for non-English languages where the translation might be longer and eventually gets truncated.

Steps to reproduce:

  1. Go to the Settings page on a small screen device

Expected behavior:
The Settings text for 'Automatically get current location' should not be truncated.

Observed behavior:
Part of the settings text is truncated.

Device and Android version:
Samsung Galaxy j1 ace (5.1.1, 4.3")

Commons app version:
2.7.2

Screen-shots:
screenshot_2018-06-27-19-38-15

Would you like to work on the issue?
No

Note
There was a similar issue in the Wikipedia app which recently got fixed.

@seannemann21
Copy link
Contributor

I submitted a pull request! I didn't even notice the note at first, but still ended up fixing it the same way haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants