Skip to content

Allow for settings titles to expand across multiple lines instead of being truncated #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2018

Conversation

seannemann21
Copy link
Contributor

Expand settings title across multiple lines

Fixes #1670

Description

Allow for settings titles to expand across multiple lines instead of being truncated

Fixes #1670, Setting text is truncated when space is not available

Tests performed (required)

Tested on API level 24 on Samsung Galaxy S6, with ProdDebug.

Screenshots showing what changed

Note that I only changed the setting title to show what a long title would look like. I reverted the title to the correct one before creating the pull request
image

@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #1671 into master will increase coverage by 0.36%.
The diff coverage is 56.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1671      +/-   ##
=========================================
+ Coverage    3.85%   4.21%   +0.36%     
=========================================
  Files         153     158       +5     
  Lines        7661    7714      +53     
  Branches      714     719       +5     
=========================================
+ Hits          295     325      +30     
- Misses       7349    7367      +18     
- Partials       17      22       +5
Impacted Files Coverage Δ
...s/ui/LongTitlePreferences/LongTitlePreference.java 54.54% <54.54%> (ø)
...gTitlePreferences/LongTitleEditTextPreference.java 54.54% <54.54%> (ø)
...gTitlePreferences/LongTitlePreferenceCategory.java 54.54% <54.54%> (ø)
...ongTitlePreferences/LongTitleSwitchPreference.java 54.54% <54.54%> (ø)
.../LongTitlePreferences/LongTitleListPreference.java 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cfe709...90a82bb. Read the comment docs.

@neslihanturan
Copy link
Collaborator

neslihanturan commented Jul 22, 2018

It seemed to me like too much code repetition. But even after searching some other examples, I couldn't find another better approach. I thik this is the way to do this.

Thanks @seannemann21 ! Can you please solve conflicts?

@seannemann21
Copy link
Contributor Author

Whoops, sorry, I didn't notice the conflict, and it has been awhile since I have looked at this. It should be resolved now though! Thanks!

@neslihanturan
Copy link
Collaborator

Conflics happened because of late review of mine actually:)

@neslihanturan neslihanturan merged commit 1bf5dda into commons-app:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants