App doesnot ask for permission when multiple pics are shared

[parth96]

Summary:

App doesnot ask for storage permission when multiple pics are shared through gallery.

Steps to reproduce:
1.Select pics you want to share through any gallery.
2.Click on the share button.
3.Select the commons app from the recommended app list.
4.The dialogue box which should appear asking for storage permission doesnot appear.

Device and Android version:
Motorola G(4) (android 7.0,API 24).

Commons app version:
2.7.2-debug-master~d7b956e5

Screen-shots:

Would you like to work on the issue?
Yes i would like to work on this issue.

[misaochan]

Please feel free to work on this, @parth96 . :)

[VaishSiddharth]

@misaochan Can i work on this?

[misaochan]

@parth96 Are you still interested in working on this?

[parth96]

Sorry,I am engaged in something else won't be able to work on it.

[misaochan]

It's yours @VaishSiddharth . :)

[VaishSiddharth]

@misaochan I plan to ask for user permission and then the activity will finish. When the user will again start the upload from gallery it will work as expected and the upload will begin. Is this ok?

[misaochan]

Can you not proceed with the upload after permission is granted?

[VaishSiddharth]

@misaochan Ok i will try to do that but i am not sure about how to do it.

[ashishkumar468]

Is this issue still open, although I could see the dialog to ask for permissions when sharing multiple images from gallery, the negative cases where the user chooses deny is not handled, we can may be show him a dialog to let him know why we need the permission, and then prompt him again. Also if I choose deny (never ask again), I could see that that now sharing through gallery shows nothing (actually the activity's finish()) is called, which appears to the user as if the app has crashed. My suggestion was to handle negative cases over here and maybe show appropriate dialogs wherever required so that the user might understand and actually give us the permissions.

[misaochan]

@ashishkumar468 Sounds like a good plan, and indeed this would work well with #1773 .

@VaishSiddharth Have you made any progress on this just yet? If not, would you mind us assigning this task to AshishKumar? As I notice that you currently have a few tasks that you are already working on. :)

[ashishkumar468]

Yes, waiting on @VaishSiddharth for his update .

[VaishSiddharth]

@ashishkumar468 Yes you can work on this. :)