Nearby crashes when Home [From the Nav Drawer] is pressed while nearby is still loading data

[ashishkumar468]

Summary:
If we press home while nearby is still loading data, nearby crashes.

Steps to reproduce:

Click on Nearby and while its loading data, click on home from the nav drawer, nearby crashes with InterruptedIOException

Add System logs:

Add logcat files here (if possible).

Caused by: java.io.InterruptedIOException: thread interrupted
        at com.android.okhttp.okio.Timeout.throwIfReached(Timeout.java:145)
        at com.android.okhttp.okio.Okio$1.write(Okio.java:78)
        at com.android.okhttp.okio.AsyncTimeout$1.write(AsyncTimeout.java:155)
        at com.android.okhttp.okio.RealBufferedSink.flush(RealBufferedSink.java:221)
        at com.android.okhttp.internal.http.HttpConnection.flush(HttpConnection.java:141)
        at com.android.okhttp.internal.http.HttpTransport.finishRequest(HttpTransport.java:60)
        at com.android.okhttp.internal.http.HttpEngine.readNetworkResponse(HttpEngine.java:1154)
        at com.android.okhttp.internal.http.HttpEngine.readResponse(HttpEngine.java:976)
        at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:509)
        at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:438)
        at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:247)
        at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210)
        at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java)
        at fr.free.nrw.commons.nearby.NearbyPlaces.getFromWikidataQuery(NearbyPlaces.java:84)
        at fr.free.nrw.commons.nearby.NearbyPlaces.getFromWikidataQuery(NearbyPlaces.java:48)
        at fr.free.nrw.commons.nearby.NearbyController.loadAttractionsFromLocation(NearbyController.java:56)
        at fr.free.nrw.commons.nearby.NearbyActivity.lambda$refreshView$7$NearbyActivity(NearbyActivity.java:438)
        at fr.free.nrw.commons.nearby.NearbyActivity$$Lambda$7.call(Unknown Source)

Device and Android version:

Samsung s7 api 27

Commons app version:
2.8.1-debug-master~4ea72298

Screen-shots:
NA

Would you like to work on the issue?
Yes

[ashishkumar468]

Can someone please review this ?

[maskaravivek]

Please go ahead and fix it if you can. :)

[maskaravivek]

Does it also happen on latest master?

[VojtechDostal]

Cannot reproduce this bug in 2.8.2.

Anyone?

[ashishkumar468]

Actually my version is 2.8.1

[maskaravivek]

@ashishkumar468 If this is not happening in the latest version of the app, then we can probably close it. Let us know if you are still facing an issue.

[ashishkumar468]

@maskaravivek I am still getting the issue in 2.8-release, the same steps as mentioned, @VojtechDostal Did you use the exact same steps as as I have mentioned?, ie. Click on Nearby and while its loading data, click on home from the nav drawer, nearby crashes with InterruptedIOException.

[maskaravivek]

IMO, it might not be reproducible every time especially on faster networks. If it is still happening on the latest master, you can go ahead and add handling for InterruptedIOException.

Anyways will try to test if it happens for me as well.

[ashishkumar468]

@maskaravivek Yes, might be the case that I will not be easily reproducible in fast networks. Still the issue persists and can be easily realised from the code. Have added a fix for the same. It would be great if you could review #1847

[maskaravivek]

The corresponding PR has been merged. Closing this issue. Thanks @ashishkumar468