Issue with underscore being inserted into username

[misaochan]

From a user on our google groups forum on 13 Sep:

Hi,

thanks for your great app.

Since some days, the app doesn't add, the date of the picture into the template. Is this my fault (wrong settings) or is this a problem with the app?

And the app puts an underscore into my username. Normally it is “Z thomas“. But since two days it is turned into “Z_thomas“

Very strange bug! I don't recall making any changes in 2.8.3 or 2.8.2 that should affect usernames? @maskaravivek @neslihanturan

[misaochan]

Oops, I just realized that we already had an issue for the date at #1854 . I'll modify this issue to make it solely about the underscore.

[misaochan]

More info:

Here is the timetable of the occuring problems:

Problem DATE

• 2018-09-01 upload picture "File:Rosengarten Dresden Skulptur 20180827 -9.jpg" WITH date and WTIHOUT underscore in Username
• 2018-09-03 upload picture "File:Leuschnerdamm 13 Berlin Kreuzberg - 3.jpg" WTIHOUT date and WTIHOUT underscore in Username

I'm not sure if I updated the App between these two days

Problem UNDERSCORE

• 2018-09-11 Time 17:50 upload "File:Augsburger Straße dresden 2018-09-11 1.jpg" WTIHOUT date and WTIHOUT underscore in Username
• 2018-09-11 between 17:50 and 17:59 deinstall and new insall Commons Upload App because of problems with batch upload
• 2018-09-11 Time 17:59 upload "File:Behrischstraße dresden 2018-09-11 - 2.jpg" WITHOUT date WITH underscore in Username

[VojtechDostal]

For me, this issue started between 4th and 13th August - see my contribs at https://commons.wikimedia.org/wiki/Special:ListFiles/Vojt%C4%9Bch_Dost%C3%A1l

[hoplite390]

@misaochan @VojtechDostal Hi guys, the underscore issue might be present from 15 Jun 2017. Older posts from @VojtechDostal are with underscore as well. I did not check all of them but it seems to be isolated to his pictures with "Uploaded using Commons Mobile App" in detail. Oldest one from them is https://commons.wikimedia.org/wiki/File:N%C3%A1m%C4%9Bst%C3%AD_Jana_Pernera_2018.jpg. On the other hand user Z thomas posts were affected just from 11.9.2018. (Maybe he had some sort of app update after long time?)
My guess is that issue is caused by "String username = canonicializeUsername(usernameEdit.getText().toString());" canonicializeUsername replace space with "_" . I can probably fix that, however i cant predict if that will cause more errors, because there might be some reason why the Author of PageTitle.java normalized usernames like that.

[domdomegg]

Fixed in #1982