Skip to content

When no internet, nearby stays grey, no spinner nor error #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-raoul opened this issue Oct 10, 2018 · 2 comments
Closed

When no internet, nearby stays grey, no spinner nor error #1921

nicolas-raoul opened this issue Oct 10, 2018 · 2 comments
Labels
enhancement good first issue nearby

Comments

@nicolas-raoul
Copy link
Member

  1. With no Internet,
  2. Go to Nearby
  3. Result: grey screen. Expected: information or spinner
@spelka
Copy link
Contributor

spelka commented Oct 10, 2018

I'm having a look at this one.

@misaochan
Copy link
Member

Thanks @spelka !

@spelka spelka mentioned this issue Oct 11, 2018
Merged
domdomegg pushed a commit that referenced this issue Nov 3, 2018
@spelka @domdomegg
Fix #1921, missing information about internet connectivity on nearby …
ef73204 
…page

The reported issue is that in the Nearby activity, the app does not communicate that there is no internet connection. On investigation, it appears that a toast message does briefly display "No internet connection". It looks like other activities have implemented this same message within the snackbar instead. In order to have a consistent style of communication to the user, I removed the toast message and replace it with the snackbar message, as implemented in NotificationActivity.java.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue nearby
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-raoul @misaochan @spelka