-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow dynamic loading of contributions, without number limit #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think the ideal solution would be to implement My Uploads like it is done in Explore:
|
Agreed. Will change the title accordingly. |
I would like to pick this up. |
@maskaravivek Don't hesitate to use the "Assignees" button to assign issues to yourself :-) |
The code in contributions fragment and contribution list fragment is quite old and things have been patched on top of it. One of the focus areas of the next grant is to overhaul legacy code(#1092) and introduce a consistent code pattern across the app. So, before starting working on this talk it would be great if we could finalize the architecture for the presentation layer. Let's continue the discussion for the architecture in #888. |
@ashishkumar468 Recently you refactored the contributions list. Can you confirm if this has already been taken care of? |
@maskaravivek my refactors did not change the way things were already there. AFAIK I know such things would need pagination at the end of the recycler view which is not there as of now |
There was a request on our mailing list:
While there are bandwidth and memory concerns with downloading large numbers of images, I personally think if the user decides they want to, we should allow it (however the default should remain the same as currently). Currently the max you can set in Settings is 500. Would this be a good idea?
The text was updated successfully, but these errors were encountered: