Upload failures after v2.8 #2013
Comments
|
Yep I had some upload failures yesterday. |
|
@VojtechDostal Logging in and out again works for you, right? As a short-term measure we could add that suggestion to a "Failed upload" toast via #1556 so that other users aren't stuck not knowing what to do. We will do an overhaul of the authentication flow in the next PG if approved. |
|
Logout and login doesn't solve upload failure, which happen say 2 out of 3 attempts. |
|
@cascafico Hmm, interesting, so the failures are not constant for you? Are you in beta testing? If you are, could you please go to Settings > Send Logs > enable the permissions. Then restart app > try to upload > tap Send Logs again after you experience a failure? This will help us debug the cause of the failure for you. Thanks! |
|
Thanks for the logs. This is very strange, it is a badtoken error as well, but this is the first one I have seen that relogging does not fix. @maskaravivek Could you please take a look at the logs as well? Thanks. |
|
Btw, @cascafico , do you have 2FA enabled on your account by any chance? |
|
No, I don't
|
|
@misaochan @maskaravivek @nicolas-raoul I was working on the upload issue, refactored the LoginActivity and UploadService, but none of it could actually solve the bad token issue. After debugging a lot, I could produce it and found that, even after fetching fresh c-auth token, we get a bad token error as if we are not logged in. I was hoping that some one who has more experience with the api's could suggest me a better approach to this. I would also recommend that we pick up a task of refactoring the network layer as it the code base it to coupled and prone to bugs. |
|
As per discussion with @ashishkumar468 and @maskaravivek , our current plans for fixing this in PG 2019: Revamp network layer, at the very least the login/getToken APIs need to be migrated to OkHttp |
|
Several users have reported this fixed. :) Closing, feel free to reopen if needed. |
It seems that we are still encountering upload failures after 2.8, albeit with much lower frequency. I had them today when testing #1968 (however, I created this issue because I don't think it is relevant to that PR, which doesn't alter the auth flow), and had them once on my real device recently.
Logs below from API 27 Nexus S emulator. Interestingly, after seeing this failure, I checked Achievements to see if I was indeed not logged in. However, Achievements works perfectly fine! So my conclusion is that it is the edit tokens that are the issue, not the actual login. @maskaravivek
The text was updated successfully, but these errors were encountered: