Skip to content

Increase timeout for achievements #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neslihanturan opened this issue Dec 3, 2018 · 6 comments
Closed

Increase timeout for achievements #2066

neslihanturan opened this issue Dec 3, 2018 · 6 comments

Comments

@neslihanturan
Copy link
Collaborator

neslihanturan commented Dec 3, 2018

Summary:

As I noted under this PR #2056, for our user Ainali, who reported this issue, 30 seconds wasn't enough on first trial. So we may need to increase it to maybe 40?

Steps to reproduce:
private void setAchievements() {
progressBar.setVisibility(View.VISIBLE);
if (checkAccount()) {
compositeDisposable.add(mediaWikiApi
.getAchievements("Ainali")
`

You can test achivements for a specific username by editing username in shared code part

@maskaravivek
Copy link
Member

IMO, we can set the timeout to 60 seconds. As a future enhancement, we can show a more verbose loading indicator so that the user doesn't get impatient.

@ashishkumar468
Copy link
Collaborator

Although 60 is a lot, but considering out current scenario, I agree with @maskaravivek considering the worst cases

@maskaravivek
Copy link
Member

Yes, with 60 seconds it is up to the user to wait or not. Also, we know of instances where the API is actually taking more than 30 secs.

@ashishkumar468
Copy link
Collaborator

I will go ahead and add a patch for the same

@misaochan
Copy link
Member

Sounds good to me.

@domdomegg
Copy link
Member

Fixed in #2080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants