Bug fix #2042 Achievements is blank for some users. #2056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a snack with retry when api in AA fails * Increased connection timeouts in okhttpclient builder
Collaborator
|
Thanks @ashishkumar468 . I have tested this PR:
|
Codecov Report
@@ Coverage Diff @@
## 2.9-release #2056 +/- ##
==============================================
+ Coverage 4.06% 4.07% +0.01%
==============================================
Files 224 224
Lines 11311 11329 +18
Branches 1045 1046 +1
==============================================
+ Hits 460 462 +2
- Misses 10817 10833 +16
Partials 34 34
Continue to review full report at Codecov.
|
Collaborator
Author
|
@neslihanturan Strange, works for me, what happens when you click on retry ? |
Collaborator
|
Progress bar appears, then it displays retry button again. |
Collaborator
|
Well, it worked this time. I think it took some time my emulator turn on connection, and I tested fast. So code should be fine. Thanks @ashishkumar468 ! |
Member
|
Has anyone tested this by putting Ainali's username into the debugger to check the API response? |
Collaborator
|
I just tried, it didn't worked on first trial. Then I retried, it worked. So we should set timeouts for longer periods. |
Contributor
|
Hey i have made some changes here. May be this can solve the concerned issue. |
neslihanturan
pushed a commit
that referenced
this pull request
Dec 19, 2018
* Fix memory leak due to wikidata edit listener (#2048) * Fix bookmark crash fix (#2047) * Fix bookmark crash fix * Fix check for bookmark creator * Bug fix #2042 (#2056) * Bug fix #2042 * Added a snack with retry when api in AA fails * Increased connection timeouts in okhttpclient builder * added missing string resource * Bugfix/duplicate categories (#2080) * Increased timeout to 60 seconds * Bug fix #1550 * filter duplicate categories * Fix crash because of inactive fragment UI (#2046) * Fix crash because of inactive fragment UI * Add java docs * Add information icon action Fiixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything (#2057) * Localisation updates from https://translatewiki.net. * Remove unused mediawiki api dependency (#1991) * Categories with pipe suffix (#1873) * Bug fix issue #1826 Changes made : -Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe * review suggested changes *Code formatting *Extracted out the index of pipe in a variable *Added issue link in comments * Remove libraries section from README (#1988) * Remove libraries section from README * Add wiki link to "libraries used" to README * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Use alert dialog instead of popup window, for nearby information * Revert irrelevant changes, sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
When the api call to fetch the achievements somehow fails, a blank screen shows up and user is left with no option to retry.
Fixes #2042 Achievements is blank for some users.
What changes did you make and why?
Tests performed (required)
Tested {build variant, ProdDebug} on {One Plus 3T} with API level {27}.
Screenshots showing what changed (optional - for UI changes)
