Skip to content

SearchActivity tab names are hardcoded #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
domdomegg opened this issue Dec 16, 2018 · 0 comments
Closed

SearchActivity tab names are hardcoded #2136

domdomegg opened this issue Dec 16, 2018 · 0 comments
Labels
good first issue localization

Comments

@domdomegg
Copy link
Member

Summary:

SearchActivity has the tab names ("MEDIA" and "CATEGORIES") hardcoded. These should be extracted into strings.xml with appropriate names so they can be translated.

See lines 96 and 98.
cypherop added a commit to cypherop/apps-android-commons that referenced this issue Dec 16, 2018
@cypherop
Defined SearchActivity tab names into strings.xml file(commons-app#2136)
2a510f7
@cypherop cypherop mentioned this issue Dec 16, 2018
Merged
cypherop added a commit to cypherop/apps-android-commons that referenced this issue Dec 17, 2018
@cypherop
some minor changes in strings.xml file(commons-app#2136)
95bb707
domdomegg pushed a commit to cypherop/apps-android-commons that referenced this issue Dec 17, 2018
@cypherop @domdomegg
Defined SearchActivity tab names into strings.xml file(commons-app#2136)
58ed765
domdomegg pushed a commit to cypherop/apps-android-commons that referenced this issue Dec 17, 2018
@cypherop @domdomegg
some minor changes in strings.xml file(commons-app#2136)
baa5dfd
domdomegg pushed a commit that referenced this issue Dec 17, 2018
@cypherop @domdomegg
Defined SearchActivity tab names into strings.xml file(#2136) (#2137)
11e5c3c 
* Defined SearchActivity tab names into strings.xml file(#2136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue localization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@domdomegg