When uploading a single image the category and license selector implies plural #2163
Labels
Comments
|
@domdomegg Thanks for finding and creating issues which beginners can pick up. :) |
|
@domdomegg I'd like to pick this. Check the number of images and hide the view if it is only one image could fix this issue. |
zhao-gang
added a commit
to zhao-gang/apps-android-commons
that referenced
this issue
Dec 19, 2018
zhao-gang
added a commit
to zhao-gang/apps-android-commons
that referenced
this issue
Dec 20, 2018
zhao-gang
added a commit
to zhao-gang/apps-android-commons
that referenced
this issue
Dec 20, 2018
maskaravivek
pushed a commit
that referenced
this issue
Jan 1, 2019
* Hide subtitle message when uploading a single image (#2163) * updateSubtitleVisibility: Javadoc and replace if with ternary operator * updateSubtitleVisibility: change findViewById to BindView * Remove null checks for views Null check is not required while binding views with butterknife.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary:
When uploading a single image there's is the message
(For all images in set). While it still kind of works (as it's a set of 1 image), it does feel a bit weird. Think it would be better just being hidden in the case of uploading 1 image.Sorry to keep being so specific about these details, but I do think it improves the overall 'polish' of the app.
@ravi-kishan or @zhao-gang one (one!) of you might want to take this up given it's probably quite similar to #2156.
Screen-shots:
The text was updated successfully, but these errors were encountered: