Skip to content

Make achievements activity more discoverable #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vanshikaarora opened this issue Jan 16, 2019 · 16 comments · Fixed by #5442
Closed

Make achievements activity more discoverable #2307

vanshikaarora opened this issue Jan 16, 2019 · 16 comments · Fixed by #5442

Comments

@vanshikaarora
Copy link
Contributor

vanshikaarora commented Jan 16, 2019

Achievements activity is currently accessed by clicking the icon. And that icon might not seem clickable to some general user

Why should we consider this?

  • Presently there is no mention of achievements activity or any leaderboard in the app's tutorial
  • Currently the icon is displayed over another image in the navigation drawer.
  • To most general users the icon might not be percieved as a clickable element or it may be considered as a UI element.

What can we do?

  • Since the learderboard is an activity. We can add it like another option in the navigation drawer
  • Or if this icon looks significantly impressive to users then we can add the same icon to the toolbar

More suggestions on this opinion are highly appreciated :)

Would you like to work on the issue?
Yes

@nicolas-raoul
Copy link
Member

While I agree that it is not visible enough now, I don't think adding another item to the navigation drawer is good, as it is already long. Displaying the current level of the user visible would certainly make it more attractive (for instance: Alaxandrea, level 7).

@vanshikaarora
Copy link
Contributor Author

I don't think adding another item to the navigation drawer is good, as it is already long.

Accepted

How about adding the same icon to the toolbar?

Alternatively

Yes we can add the level of the user:
That adds a value. I can add a suggestion here how about adding this tutorial https://github.com/KeepSafe/TapTargetView for the first time when user uses this app.

@vanshikaarora
Copy link
Contributor Author

@nicolas-raoul So what should i start with?

  • Adding level number in place of icon
  • Or Add the tutorial as mentioned in the previous link

I'll start working upon this soon afterwards

@nicolas-raoul
Copy link
Member

I don't think it is important enough to add a tutorial step, a tutorial should only show features that are essential to get started.

Adding the level number means getting that number in the first place, which is not really easy, and would hurt performance if implemented incorrectly.

Since the achievement activity is currently broken, I don't think this is an issue we should focus on right now, so I suggest starting work on other tasks :-)

@vanshikaarora
Copy link
Contributor Author

ok I'll see other tasks

@nicolas-raoul nicolas-raoul changed the title Make Achievements activity more acessible Make achievements activity more discoverable Jan 17, 2019
@Tanvi-Goyal
Copy link

Hi i would like to work on this issue.

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 5, 2019

@Tanvi-Goyal Assigned to you :-)

The current idea is to display the level number next to the user name.
Since the current achievements API is slow, this issue probably requires caching the level number (and only requesting it when it is absent or very old and also when the user enters the achievements activity.

@Tanvi-Goyal
Copy link

Can't we add the icon in the appbar left of the notiification icon.
Please consider else i will start working on the level number idea.
Thanks

@vanshikaarora
Copy link
Contributor Author

Hey, If no-one is working on this Issue or shall I take this up?

@nicolas-raoul
Copy link
Member

@Tanvi-Goyal That's an idea we can keep in mind, but I feel that near the username makes the user really feel that their achievements are associated to them. Did you get a chance to start caching the level or anything towards completing this issue? If yes please commit and push, even if it is not complete, thanks :-)

@ShashwatKedia
Copy link
Contributor

@nicolas-raoul I would like to work on this issue, could you please tell me what are we finally gonna implement for this issue?

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Jan 9, 2024

Actually due to a UI revamp, the activity is now much more discoverable.

I suggest either:

  1. closing this issue,
  2. or changing the menu item from TheUser to TheUser's achievements. This must be internationalized.

@ShashwatKedia Do you want to try option 2?

@ShashwatKedia
Copy link
Contributor

Sure, I would love to try that. @nicolas-raoul to confirm, if the username is Tester051005 with level 1, then in the menu, we want to show Tester051005 ( Level 1)

For caching the user level, I suggest storing the level in SharedPrefs.

Here right?
Issue

@ShashwatKedia
Copy link
Contributor

@nicolas-raoul I tried to implement this and successfully stored the user level and displayed it in the menu item next to the username. But this works only after the user visits the achievements fragment once, since the data has to be fetched first; only then can I store it. So, when a user freshly installs and opens the app, the menu will display only their username but will show their level after visiting the achievements fragment once. Either we can go with this approach or close the issue since fetching data beforehand, just for the sake of showing level in the menu, doesn't seem feasible.

@nicolas-raoul
Copy link
Member

Yes your screenshot shows the right place.

Tester051005 (Level 1) sounds good!

If the level is unknown yet, how about displaying Tester051005 (see your achievements)?

@ShashwatKedia
Copy link
Contributor

ShashwatKedia commented Jan 15, 2024

If the level is unknown yet, how about displaying Tester051005 (see your achievements)?

Sounds great! It will make the user curious and tempt them to open it, nice. I'll do as required

ShashwatKedia added a commit to ShashwatKedia/apps-android-commons that referenced this issue Jan 15, 2024
ShashwatKedia added a commit to ShashwatKedia/apps-android-commons that referenced this issue Jan 15, 2024
nicolas-raoul added a commit that referenced this issue Jan 17, 2024
* Resolves #2307 by adding user level in menu

* Formatted code as requested

* Start sentence with uppercase

* javadoc

* Fixed my typo

* javadoc

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants