-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make achievements activity more discoverable #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
While I agree that it is not visible enough now, I don't think adding another item to the navigation drawer is good, as it is already long. Displaying the current level of the user visible would certainly make it more attractive (for instance: |
Accepted How about adding the same icon to the toolbar? AlternativelyYes we can add the level of the user: |
@nicolas-raoul So what should i start with?
I'll start working upon this soon afterwards |
I don't think it is important enough to add a tutorial step, a tutorial should only show features that are essential to get started. Adding the level number means getting that number in the first place, which is not really easy, and would hurt performance if implemented incorrectly. Since the achievement activity is currently broken, I don't think this is an issue we should focus on right now, so I suggest starting work on other tasks :-) |
ok I'll see other tasks |
Hi i would like to work on this issue. |
@Tanvi-Goyal Assigned to you :-) The current idea is to display the level number next to the user name. |
Can't we add the icon in the appbar left of the notiification icon. |
Hey, If no-one is working on this Issue or shall I take this up? |
@Tanvi-Goyal That's an idea we can keep in mind, but I feel that near the username makes the user really feel that their achievements are associated to them. Did you get a chance to start caching the level or anything towards completing this issue? If yes please commit and push, even if it is not complete, thanks :-) |
@nicolas-raoul I would like to work on this issue, could you please tell me what are we finally gonna implement for this issue? |
Actually due to a UI revamp, the activity is now much more discoverable. I suggest either:
@ShashwatKedia Do you want to try option 2? |
Sure, I would love to try that. @nicolas-raoul to confirm, if the username is Tester051005 with level 1, then in the menu, we want to show Tester051005 ( Level 1) For caching the user level, I suggest storing the level in SharedPrefs. |
@nicolas-raoul I tried to implement this and successfully stored the user level and displayed it in the menu item next to the username. But this works only after the user visits the achievements fragment once, since the data has to be fetched first; only then can I store it. So, when a user freshly installs and opens the app, the menu will display only their username but will show their level after visiting the achievements fragment once. Either we can go with this approach or close the issue since fetching data beforehand, just for the sake of showing level in the menu, doesn't seem feasible. |
Yes your screenshot shows the right place.
If the level is unknown yet, how about displaying |
Sounds great! It will make the user curious and tempt them to open it, nice. I'll do as required |
Achievements activity is currently accessed by clicking the icon. And that icon might not seem clickable to some general user
Why should we consider this?
What can we do?
More suggestions on this opinion are highly appreciated :)
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: