Skip to content

Notification activity: Dates not localized #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-raoul opened this issue Jan 23, 2019 · 4 comments
Closed

Notification activity: Dates not localized #2332

nicolas-raoul opened this issue Jan 23, 2019 · 4 comments
Labels
bug good first issue localization

Comments

@nicolas-raoul
Copy link
Member

Steps to reproduce:

  1. Set language to another language than English that has 100% translation on translatewiki (such as French)
  2. Open app
  3. Go to notifications activity
  4. Notice that the dates are in English

screenshot_20190123-133905
@ravi-kishan
Copy link
Contributor

I would like to work on this

@maskaravivek
Copy link
Member

Sure take this up @ravi-kishan :)

@maskaravivek
Copy link
Member

@ravi-kishan Are you still working or this issue? If not, the function added in @vanshikaarora's PR can be used to fix this issue as well.

@ravi-kishan
Copy link
Contributor

I could not get to an efficient solution. You may use that pr to fix this issue.

deniger added a commit to deniger/apps-android-commons that referenced this issue Mar 7, 2019
@deniger
commons-app#2332 add param "uselang" in notifications API calls.
376e4bc 
The value is the user language. If null or empty the value "user" is used
@deniger deniger mentioned this issue Mar 7, 2019
Merged
maskaravivek pushed a commit that referenced this issue Mar 9, 2019
@deniger @maskaravivek
#2332 add param "uselang" in notifications API calls. (#2555)
a4238c0 
The value is the user language. If null or empty the value "user" is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue localization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-raoul @maskaravivek @ravi-kishan