-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Replace toasts with snackbars where appropriate #2388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, i want to work on this issue. |
@Tanvi-Goyal |
I've already sent a PR which awaits a review. |
@nicolas-raoul @ShridharGoel I suggest using CSnackBar Library for this task :) |
@nicolas-raoul @4D17Y4 I want to work on this issue please assign me |
@neslihanturan Do you think this is a good idea, actually? If yes, Rishav can work on it. @madhurgupta10 Is a library really needed? The PR #2389 does not seem to use any. |
@nicolas-raoul External library not needed for this task. Also, we should not be replacing every single Toast with Snackbar Links for reference Lastly, if someone wants to work on this issue, please also update the unit tests accordingly. |
@Rishavgupta12345 you already have quite a few issues assigned, if you still want to work on this task afterwards please ask again, thanks :-) |
@nicolas-raoul @4D17Y4 work on previous issues is completed , please assign me this one |
@nicolas-raoul I guess I will be able to fix the failing tests in #4920. |
Hello, Proposed Solution Can I get assigned to it? @nicolas-raoul |
@shankarpriyank I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-) |
Summary:
App uses toasts at many places which can be replaced by Snackbars for better UI.
Commons app version:
Latest master
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: