Skip to content

Fixes #2388 Replace Toasts with Snackbars #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes #2388 Replace Toasts with Snackbars #5585

wants to merge 1 commit into from

Conversation

neeldoshii
Copy link
Contributor

@neeldoshii neeldoshii commented Mar 2, 2024 •
edited
Loading

Fixes

Purpose/ Description

I have used the methods of Snackbars from ViewUtil and utilized it to convert some toasts to Snackbar.
Note : It doesn't refactor every toast but it covers most of the toasts to snackbar.

Video

Permission Utils Toast (Before)

ca87981c-e06c-4deb-b0a7-e17a0545b06a.mp4

Permission Utils Snackbar (After)

permission_snackbar.webm

Depiction Toast (Before)

depiction.webm

Depiction Snackbar (After)

depiction.mp4

**Recent Search Toast(Before)

recent_search.mp4

**Recent Search Snackbar(After)

recent_search.mp4

@neeldoshii neeldoshii force-pushed the Replace-toasts-with-snackbars-#2388 branch from 158850c to f5f79d2 Compare March 2, 2024 18:28
@neeldoshii neeldoshii marked this pull request as ready for review March 2, 2024 20:33
@neeldoshii neeldoshii force-pushed the Replace-toasts-with-snackbars-#2388 branch from c9f4ec6 to 3ba2aa4 Compare March 8, 2024 15:05
@nicolas-raoul
Copy link
Member

Sorry for the delay in reviewing this!
Would you mind fixing the conflicts and unit tests?
Thanks!

nicolas-raoul
nicolas-raoul requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict

@neeldoshii
Copy link
Contributor Author

neeldoshii commented Dec 6, 2024 •
edited
Loading

Completing my leftover PR task.
Things have changed a lot from the time I implemented initially.

Current approach what I am planning

  1. Clear all commits full fresh start.
    2. Create a composable SnackBar widget utility object. Edit : In order to render the compose snackbar I will need the layout to be in either compose or view in compose.

Reason:

  • Slow migration towards Material 3
  • Initial small steps towards getting close to getting compose.
  • Removing toast completely from the app.

@neeldoshii neeldoshii mentioned this pull request Dec 6, 2024
Open
@neeldoshii neeldoshii closed this Dec 6, 2024
@neeldoshii neeldoshii force-pushed the Replace-toasts-with-snackbars-#2388 branch from 3ba2aa4 to b5ce7c7 Compare December 6, 2024 19:07
@neeldoshii neeldoshii reopened this Dec 7, 2024
@nicolas-raoul
Copy link
Member

Should this be a draft? 🙂

@neeldoshii neeldoshii marked this pull request as draft December 7, 2024 03:55
@neeldoshii
Copy link
Contributor Author

Should this be a draft? 🙂

Yes, my bad

@neeldoshii neeldoshii closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace toasts with snackbars where appropriate
2 participants
@neeldoshii @nicolas-raoul