Skip to content

Achievements activity share option is not working. #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
prajurock opened this issue Feb 5, 2019 · 2 comments
Closed

Achievements activity share option is not working. #2416

prajurock opened this issue Feb 5, 2019 · 2 comments
Labels
gamification

Comments

@prajurock
Copy link

Summary:
On clicking the share option on achievement activity App closes.

Device and Android version:
Asus Zenfone Max m1 pro(API 27)

Commons app version:

latest master version

Gif

video2gif_20190205_223545

Would you like to work on the issue?

Yes
prajurock added a commit to prajurock/apps-android-commons that referenced this issue Feb 6, 2019
@prajurock
Achievements activity share option is not working. commons-app#2416
13a1230
@thomas154
Copy link
Contributor

I would like to work on this.

thomas154 added a commit to thomas154/apps-android-commons that referenced this issue Feb 15, 2019
@thomas154
Fix achievements activity share option (commons-app#2416)
9a8c618 
* Use fileProvider instead of Uri.fromFile()
* As Uri.fromFile() will not work on Android 7.0+, with a targetSdkVersion of 24 or higher, throws FileUriExposedException
@thomas154 thomas154 mentioned this issue Feb 15, 2019
Merged
@prajurock
Copy link
Author

@thomas154 You can proceed.

maskaravivek pushed a commit that referenced this issue Feb 26, 2019
@thomas154 @maskaravivek
Fix achievements activity share option (#2416) (#2478)
b244e40 
* Use fileProvider instead of Uri.fromFile()
* As Uri.fromFile() will not work on Android 7.0+, with a targetSdkVersion of 24 or higher, throws FileUriExposedException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gamification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-raoul @thomas154 @prajurock