Skip to content

Show caption instead of filename (in my contributions and Explore) #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-raoul opened this issue Feb 27, 2019 · 9 comments
Closed
Labels

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 27, 2019

Caption from Structured Commons, localized in the user's language.
Fall back to filename if no caption is available.

@BinduVerma123
Copy link

Hello @nicolas-raoul i am an outreachy applicant..I would like to work on this issue.

@nicolas-raoul
Copy link
Member Author

@BinduVerma123 It is yours :-)
Here is the API you will have to use: #2337 (comment)

@cypherop
Copy link
Contributor

@nicolas-raoul does this mean we should remove Title field from media details and add Captions instead of it?

@nicolas-raoul
Copy link
Member Author

Yes, if a caption is available in the user's language, it should be shown, and the title not shown.

(for those wondering: the title can still be obtained if needed via the "copy wikitext" button)

@cypherop
Copy link
Contributor

In that case some minor changes in #2662 will be enough to solve the issue.

@nicolas-raoul
Copy link
Member Author

@BinduVerma123 Any progress on this?
Please share anything you might have found out, things that worked and also things that did not work if any :-)

@nicolas-raoul
Copy link
Member Author

@vanshikaarora This needs to be implemented. It is the most important part of the GSoC to make the app more localized :-)

How to reproduce:

  1. Set Android language to English or French or Japanese
  2. Open the app
  3. Tap "Explore"
  4. Tap the search icon
  5. Enter "tantanmen"
  6. Scroll until you see this picture: https://commons.wikimedia.org/wiki/File:Tantanmen.jpeg

Expected: The app labels the picture using its caption in Android's language, for instance English or French or Japanese
Problem: The app labels the picture using its filename "Tantanmen" (which is not any of the captions)

Screenshots:
adb-screenshot

adb-screenshot

@vanshikaarora
Copy link
Contributor

@nicolas-raoul I am currently working on this :)

@nicolas-raoul
Copy link
Member Author

I believe this is now implemented in all places where titles (filenames) were shown before.
(in Vanshika's upload_caption_depict branch)
If you find any other place where captions could be used, please let us know :-)

@nicolas-raoul nicolas-raoul added gsoc Google Summer of Code and removed gsoc2019 labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants