Skip to content

When type of nearby place is unknown, let description empty rather than just "?" #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-raoul opened this issue Mar 9, 2019 · 8 comments

Comments

@nicolas-raoul
Copy link
Member

Steps to reproduce:

  1. Go to Nearby
  2. Find a place which has no type (when you tap on it then tap on the bottom panel that appears, the last line says "?"
  3. Upload a picture for it (you can cancel before the real upload)
  4. Description is pre-filled with "?"

While it makes sense to prefill if the type is "school" or "hospital", when it is "?" the description should be left empty.

Screen-shots:
Screenshot_20190224-012328

@brendajerop
Copy link
Contributor

@nicolas-raoul I'd like to work on this

@nicolas-raoul
Copy link
Member Author

@brendajerop It is yours! :-)

@brendajerop
Copy link
Contributor

@nicolas-raoul I am not able to work on this issue as of now due to complications with my computer :(. So someone else can take it up.

@vanshikaarora
Copy link
Contributor

@nicolas-raoul Shall I take this up?

@ujjwalagrawal17
Copy link
Contributor

Sure @vanshikaarora feel free to work on it.

@vanshikaarora
Copy link
Contributor

Thanks @ujjwalagrawal17 :)

@nicolas-raoul
Copy link
Member Author

@brendajerop Thanks for letting us know! :-)

@vanshikaarora
Copy link
Contributor

@nicolas-raoul @ujjwalagrawal17 I have made a Pull Request here #2586 Kindly review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants