Skip to content

Finalize some sleeping PRs #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neslihanturan opened this issue Mar 19, 2019 · 11 comments
Open

Finalize some sleeping PRs #2671

neslihanturan opened this issue Mar 19, 2019 · 11 comments

Comments

@neslihanturan
Copy link
Collaborator

neslihanturan commented Mar 19, 2019

Summary:

We have some pull requests which are nicely written in general but needs some more effort to be ready. Since their owners are not available to work on them anymore, instead of closing and deleting them, we should make them usable.

I think this tasks can be suitable for beginners. Probably not for complete beginners but if you already gained a little familiarity with the app, you can take a look at:

#1712 #1784 and #2069

If you work on top of previous changes, I hope (not sure), previous contributor will also be credited. You can checkout a new branch, pull the existing changes from the PR, commit your own changes top of it and create a new PR together with their commits and your commits top on them.

@cypherop
Copy link
Contributor

@neslihanturan I would like to work on them.
Shall i start with #2069 ?

@VitalyVPinchuk
Copy link
Contributor

Hello! Is it possible for me to try #1712 at the same time?

@noahwalugembe
Copy link

Am currently trying to close of an issue and i would like to try this #1784 as my next task.

@neslihanturan
Copy link
Collaborator Author

Thanks to all, please feel free to work as soon as you don't have another issue to work on. Seems like 3 issues are assigned

@noahwalugembe
Copy link

Is #1784 assigned to me

@nicolas-raoul
Copy link
Member

@noahwalugembe Yes OK good luck :-)

@neslihanturan
Copy link
Collaborator Author

Current status, we have an available PR for #1712
Hi @noahwalugembe and @sp2710 are you still working on your tasks?

@noahwalugembe
Copy link

Yes let me finish it up

@neslihanturan
Copy link
Collaborator Author

Sure @noahwalugembe , take your time. I just wanted to make sure it the issues are available or assigned.

@cypherop
Copy link
Contributor

I will continue my work on this after finalizing other open PR's. Until then if anyone else wants to work on this can take up this issue.

@neslihanturan
Copy link
Collaborator Author

Thanks for clarifying @sp2710 , no need to rush I was just sorting the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants