[WIP] Fixes #1244 (When selecting category, show sample images) #1784
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
=========================================
- Coverage 3.63% 3.63% -0.01%
=========================================
Files 182 182
Lines 9158 9169 +11
Branches 796 798 +2
=========================================
Hits 333 333
- Misses 8803 8814 +11
Partials 22 22
Continue to review full report at Codecov.
|
|
Rotating the screen uploads the picture again, it seems. |
|
@ujjwalagrawal17 Am curious if this page is the same screen that is used while uploading images? |
|
Yup it's that only. Do you liked the old design more? If you want I can change the design.@maskaravivek |
|
Nope, I love the new design. I was pleasantly surprised to see such a beautiful category selection screen. Kudos to you! :) |
|
Thanks @maskaravivek . We will try to complete #66 also. It would be even more nice then. |
|
It works great, but there is still a bug when rotating the screen. |
|
Yup @nicolas-raoul . I will fix it today. |
|
This issue seems to be on Master too. I will try to fix it. |
|
@nicolas-raoul can we have a separate fix for this issue as this PR focusses on changing UI and adding support to view category details? |
|
@ujjwalagrawal17 Yes, a separate fix branch (from current 2.8-release branch) is needed. |
|
The category screen looks really nice. Isn't the font a little too big though? Maybe making the size similar to this would help but on the other hand, my example might be a little too small. |
|
Personally, I like the font size @ujjwalagrawal17 has used. It would be nice to have more opinions about it. |
|
The screenshot in the first post looks similar to the existing size if I'm not wrong? I guess if we are wanting users to tap on it, keeping the larger size would make it easier for them. |
|
Yup I haven't changed the font size. Also I am liking bigger font size. |
|
I would like to merge this, but rotating the screen still tries to re-upload the image. |
|
What is the status of this PR, @ujjwalagrawal17 ? |
|
Umm, actually I am quite busy these days due to preparations for Campus placements. I will be completing it in free time. work is left on this PR. Can we please have it on hold for sometime. Thanks |
|
Cool, thanks for the update. :) |
|
Up @ujjwalagrawal17 :) We are excited for this PR. |
|
@neslihan yup this will be a nice feature. I will try to find time to complete it soon. Sorry for the delay. |
|
If I remember correctly this issue was about this PR: #1867 |
|
@albendz , do you still interested with this issue? |
|
Like the #1712 PR, this one also requires some work. But in general, nicely implemented. I decided to note that since currently we have several beginner contributors who are looking for some tasks. IMO completing partially done tasks can be an option for beginners. |
|
But in general, nicely implemented
Thanks :)
IMO completing partially done tasks can be an option for beginners.
I agree! That's how I started as well. By the way, I had added support for
removing non-exif metadata but as far as I remember, it is completely
broken. It could be better to remove that part but there may be metadata
that is not removed even if we remove all exif.
On Mar 18, 2019 3:14 PM, "neslihanturan" <notifications@github.com> wrote:
Like the #1712
<#1712> PR, this
one also requires some work. But in general, nicely implemented. *I decided
to note that since currently we have several beginner contributors who are
looking for some tasks. IMO completing partially done tasks can be an
option for beginners.*
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1784 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHRLo64iaXIJ6ehqX6MZz9T8Axy4xuJOks5vX4MRgaJpZM4VsJEW>
.
|
|
Is rotating the screen still tries to re-upload the image. If yes can i put it in my to do list . Am currently trying to close of an issue an i would like to try this as a next thing. |
|
@noahwalugembe The first step would be to make a branch on your side (on latest master), pull from this PR to the latest master, solve the conflicts, test a bit and send a new PR towards the ujjwalagrawal17:feat_issues_66 branch mentioning the issues you found. Thanks! :-) |
Okay am going to work on this now |
|
Closing the PR as it is very old and needs more work to resolve so many conflicts than to open a new one. Also, the design of the already existing category details page while uploading seems similar. |
Description (required)
Fixes #1244 (When selecting category, show sample images)
Tests performed (required)
ManuallyTested on MOTO G5S+, with ProdDebug variant,
Screenshots showing what changed (optional)