Review: No thanks given despite "Sending Thanks: Success"

[nicolas-raoul]

As part of the review I performed, I chose to thank the uploader (why not?), and a notification tells me that it worked:

But when I look at https://www.mediawiki.org/wiki/Special:Log/thanks I do not see my thank (it was two hours ago):

[nfatma]

Can I work on this issue?

[maskaravivek]

Sure. Assigned to @nfatma

[nfatma]

I have been working on this issue for quite long. It seems to me that the API calling and use is perfect. Also when I was trying to make Request https://commons.wikimedia.org/w/api.php?action=thank&revid=108006&source=diff&token=8f9706723e33af5c950b628dceb6f7555cd2a2f0+\ via API sandbox I am getting the below error:

{
"error": {
"code": "mustpostparams",
"info": "The following parameter was found in the query string, but must be in the POST body: token.",
"*": "See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."
},
"servedby": "mw1346"
}

[neslihanturan]

Hi @nfatma can you copy the request url taken from sandbox here?

[nfatma]

sure @neslihanturan

/w/api.php?action=thank&format=json&token=34a419c2852c0e298652b8199193240c5cd3e626%2B%5C&source=diff

and here I am getting this:
{
"error": {
"code": "missingparam",
"info": "One of the parameters "rev" and "log" is required.",
"*": "See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."
},
"servedby": "mw1225"
}

[neslihanturan]

I have been working on this issue for quite long. It seems to me that the API calling and use is perfect.

Can you also share related code lines that your sentence above is about? So that I can help

I found it @nfatma

[nicolas-raoul]

@nfatma Are you still working on this issue? What are your findings? What would be the correct URL to make it work? Thanks :-)

[chaytanyasinha]

Well I have a question that the "Thanks" message is sent via mail or is it a notification on the application?

[nicolas-raoul]

It is a notification in the web application. Please create an account if you don't have one already, and try to send thanks to someone who uploaded a nice picture.

…

On Mon, 25 Nov 2019, 22:37 Chaytanya, ***@***.***> wrote: Well I have a question that the "Thanks" message is sent via mail or is it a notification on the application? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2744?email_source=notifications&email_token=AAAYKBTWNQPH5DYQVIOJB73QVPIKDA5CNFSM4HAY7KL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCNKYY#issuecomment-558159203>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYKBXG7MAP3UQTB7XWNT3QVPIKDANCNFSM4HAY7KLQ> .

[chaytanyasinha]

what is the language used in webapp

[neslihanturan]

Hey @chaytanyasinha , our app facilities using https://commons.wikimedia.org/ from android devices. When you click "view in browser" , you will see the image on browser.

[chaytanyasinha]

Yes @neslihanturan,I opened the webapp in my mobile browser.Can you please tell me in which language are the api written for the issue.

[neslihanturan]

We are using MediaWiki API for this purpose. However, we probably shouldn't need to edit the API for this issue. So, I can't understand why you need the langugage of the APı. Please make sure you read our contributors documents beforehand, you can find more information about APIs we used there.

I think for this issue we need help with investigation. If you are able to reproduce the issue please share the details here, as @nicolas-raoul did, so that we can find the solution.

[chaytanyasinha]

I did reproduced the issue and updated about it in the earlier comments @neslihanturan.

[neslihanturan]

Sorry @chaytanyasinha I can't see it. Can you please share the link of the comment you mentioned?

[chaytanyasinha]

Sorry @neslihanturan,I got confused actually I updated about the reproduction of issue in the issue #3202 and the link of the comment is: #3202 (comment)

[neslihanturan]

Thanks for the update @chaytanyasinha , can you add more info toy our test though? There are some points I couldn't understand about the comment you linked:
1 - Did you send thank or did you nominate for deletion or did you do both?
2- Is your thank succeed and given, or it succeeded but not given as described in this issue?

[chaytanyasinha]

@neslihanturan Actually I did thank for the first it succeeded but it was showing a progress in notification bar so just to test I nominated a picture for deletion and it worked on the first go.
So,I concluded that there is an issue in sending thanks as it shows it succeeded but it's still in progress according to the notification bar and it's not sent in real.

[neslihanturan]

Notification is not reliable to verify thank is worked or not, instead you should check:

But when I look at https://www.mediawiki.org/wiki/Special:Log/thanks I do not see my thank (it was two hours ago)...
as written in @nicolas-raoul 's comment. If you did this on beta cluster, you should check this on beta.

[chaytanyasinha]

Yes @neslihanturan ,In this list also I was not able to find my user name.
So I think its not working properly.

[neslihanturan]

Then, the way we make API call should be wrong. @nfatma already did great investigation though, those comments can be helpful to create the correct the API call.

[chaytanyasinha]

Yes I went through those comments and I went on the provided url.

[chaytanyasinha]

@neslihanturan @nicolas-raoul If you say I can give a try of writing new API.

[neslihanturan]

I would like to be able to combine two issues. Currently this issue and #3202 seems like the same thing. Lets discuss here.

@chaytanyasinha I think writing the new API is not the way we go. The way we make the API call should be investigated. You can use Mediawiki APı sandbox for investigation purposes. If you are willing to do in this way, please say us so that I will assign the issue to you. Otherwise, @SamuelleMollard also interested.

[chaytanyasinha]

Yes I can do this way too @neslihanturan

[neslihanturan]

Okay so this issue is assigned to @chaytanyasinha , thanks for your interest:)

[chaytanyasinha]

@neslihanturan Actually I went through MediaWiki APi Sandbox yesterday only and I came to know about this error:
{
"error": {
"code": "mustpostparams",
"info": "The following parameter was found in the query string, but must be in the POST body: token.",
"*": "See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."
},
"servedby": "mw1235"
}

[chaytanyasinha]

Currently I am going through this(https://www.mediawiki.org/wiki/Extension:Thanks#API_Documentation) so that I can find a way to solve it

[MOLLARDAmbre]

Should I try and work on it too then or would it be more efficient if I worked on an other issue then ?

[neslihanturan]

Please work on another issue @SamuelleMollard . I am currently online, if you want to pick one just left a comment under the issue and I will assign it to you if it is not already assigned.

Note:

• Do not rely on the assigned label to strictly, sometimes the label is outdated and the issue is still available.
• Following beginner friendly labels usually helps.

[MOLLARDAmbre]

Very well, I'm selecting an issue labelled 'beginner-friendly' and commenting under it then. Thanks

[chaytanyasinha]

@neslihanturan @nicolas-raoul I went through the APIs and I found them fine.Even we can see on all other wikimedia platforms its working as in the thank list I checked all other thanks are used in other platforms so I think there is problem with something else.

[chaytanyasinha]

@neslihanturan @nicolas-raoul Please reply what should I do next. As I am getting same errors nfatma got and I found the api fine as its working for other platforms.

[neslihanturan]

Actually I don't know @chaytanyasinha , since I haven't work on this issue before.

[chaytanyasinha]

It's okay @neslihanturan . So should I work on another issue or the issues which I started?

[neslihanturan]

Sure @chaytanyasinha , you can always switch between issues, just clearly say if you want to leave it so that someone else can work on.

[neslihanturan]

Actually this comment of @nicolas-raoul is beneficial for this issue too: #3202 (comment)

You can try using breakpoints to find out unexpected pattern of the method.

[sivaraam]

I think there is a slight misunderstanding here. The Thanks feature seems to be working fine. The link in the issue description clearly shows that the logs at Mediawiki were being searched. If I understand correctly, when you thank a user for uploading the image to Common the log would be found in the Commons wiki and not in Mediawiki. So, I checked the logs at Commons and guess what I found when I searched for the Thanks logs on 25March2019:

I'm not sure whether that is the Thank @nicolas-raoul was looking for. So, my theory might be wrong. But just wanted to note my observation.

[chaytanyasinha]

@neslihanturan I think I will switch to other issues.

[neslihanturan]

Oh so thanks were working according to @sivaraam 's comment. I am not closing this issue until @nicolas-raoul verifies it though. Thanks @sivaraam !

[nicolas-raoul]

Samuelle, could you please try the thank feature and see whether it appears in the log Sivaraam mentioned? Please post the log here. Thanks! 🙂

…

On Sat, 30 Nov 2019, 03:52 neslihanturan, ***@***.***> wrote: Oh so thanks were working according to @sivaraam <https://github.com/sivaraam> 's comment. I am not closing this issue until @nicolas-raoul <https://github.com/nicolas-raoul> verifies it though. Thanks @sivaraam <https://github.com/sivaraam> ! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2744?email_source=notifications&email_token=AAAYKBQ4WGJRMQ4VU27UNH3QWFQINA5CNFSM4HAY7KL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFPNQXI#issuecomment-559863901>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYKBVMJT54TJGBM5TE3R3QWFQINANCNFSM4HAY7KLQ> .

[MOLLARDAmbre]

I can try, but I have to do something before and launching android studio should take about 20 min anyway so not right now, but I am not sure I will be able to, since I have not been able to get a sending thanks:success yet to be honnest

[MOLLARDAmbre]

I can't get a sending thanks: success, no matter how i try
I'll work on #3202 and if I can fix that I will send you the logs, but for now I can't get them.
Furthermore, I can confirm that those thanks are not in the log mentioned above

[sivaraam]

FWIW, I just tried to Thank an uploader. Regardless of the fact that the I got a "Sending Thanks: Failure" notification the Thanks was indeed sent as you can see in the thanks log.

On a side note, I'm getting a "Requesting category change ..." notification despite the fact that I never chose to request a category change for the image I reviewed. The worst part is that the notification is sticky i.e., I'm not able to swipe to make it go away!

[nicolas-raoul]

@sivaraam Your last paragraph is actually another well-known bug waiting for someone to fix it :-) : #2909

[sivaraam]

@nicolas-raoul Are you still facing this issue?

I could reliably see the Thank I give to images in the Commons thank log despite the app stating that it could not successfully thank. (looks like a different issue).

[nicolas-raoul]

@sivaraam I just tried with the latest master, you are right! I guess this can be closed.