Moving GPS FAB to bottom right corner

[madhurgupta10]

Summary:
I think we should move GPS FAB to the bottom right corner. Even google maps GPS Fab is located at the right bottom and all other FAB icon we have are on the right bottom, so it makes sense to move the GPS Fab to the right-hand corner as well.

Screen-shots:

Would you like to work on the issue?
Yes

[neslihanturan]

Where do you plan to put upload FABs @madhurgupta10 ?

[madhurgupta10]

@neslihanturan I don't think that we should move the upload FAB, when clicking on a marker and the bottom list expands, it will definitely cover the GPS FAB, but I think that is ok (considering Google Maps behavior), as when a user clicks on a marker, they don't want to move around the map. Please let me know your opinions on this :)

[neslihanturan]

I don't think covering/blocking an item is a good idea, it would feel like there is a problem. Besides, since there are multiple FABs on the same screen we should keep them separated to prevent confusion, as material design guideline already doesn't suggest to use multiple FABS on same screen: https://material.io/design/components/buttons-floating-action-button.html#usage . Google Maps is mainly for using the map, so centering your location can be one of the main function of it. On the other hand the main function of our map is uploading. So upload button should be close to finger, and it is okay to having recenter button on the top IMO.

[madhurgupta10]

@neslihanturan Very well explained 👍 I agree that the main FAB should be on the right bottom corner, for our app it is Upload, so we should not move the GPS fab, but if possible we can replace the margin attributes and add unified padding to it, similar to screenshot. Unified padding for all FAB makes the UI a bit more pleasing.

[neslihanturan]

Agreed. There is a related, open PR #2780 . Please cooperate with PR owner.

Oh the PR is yours:) So please feel free to fix this too. And please consider my review on your PR

[madhurgupta10]

@neslihanturan Sure, I will update the Location FAB padding aswell :)