Fixed Padding for FAB in nearby #2779

[madhurgupta10]

Description
Fixed Padding for Upload FAB in nearby

Fixes #2779 Upload FAB Missing Padding in Nearby

Tests performed

Tested betaDebug on Xiaomi Mi A1 with API level 28.

Screenshots showing what changed

Before

After

[codecov-io]

Codecov Report

Merging #2780 into master will increase coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #2780    +/-   ##
=======================================
+ Coverage    2.83%   3.83%    +1%     
=======================================
  Files         268     267     -1     
  Lines       12774   12529   -245     
  Branches     1129    1083    -46     
=======================================
+ Hits          362     481   +119     
+ Misses      12387   12015   -372     
- Partials       25      33     +8

Impacted Files	Coverage Δ
...va/fr/free/nrw/commons/campaigns/CampaignView.java	0% <0%> (ø)	⬆️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java	0% <0%> (ø)	⬆️
...main/java/fr/free/nrw/commons/location/LatLng.java	40.81% <0%> (ø)	⬆️
...ee/nrw/commons/media/MediaDetailPagerFragment.java	0% <0%> (ø)	⬆️
...java/fr/free/nrw/commons/nearby/PlaceRenderer.java	0% <0%> (ø)	⬆️
...a/fr/free/nrw/commons/review/ReviewController.java	0% <0%> (ø)	⬆️
...a/fr/free/nrw/commons/media/model/ExtMetadata.java	0% <0%> (ø)	⬆️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java	0% <0%> (ø)	⬆️
...fr/free/nrw/commons/settings/SettingsFragment.java	0% <0%> (ø)	⬆️
.../nrw/commons/category/CategoryDetailsActivity.java	0% <0%> (ø)	⬆️
... and 22 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995de60...80d33fa. Read the comment docs.

[neslihanturan]

Can you please add some other screenshots with other screen sizes too, by using an emulator? Ie. tablet screen.

[madhurgupta10]

@neslihanturan I wanted to do that but the app seems to be crashing on Tablets #2766 :( EDIT: See comments below

[madhurgupta10]

@neslihanturan I was able to fix the tablet app crash issue #2766 , I will open another PR for it

[domdomegg]

The gallery icon seems to be further from the + icon now. Can this be like previously, as it looks unbalanced now. Otherwise this PR seems good.

[madhurgupta10]

@domdomegg That is because of extra FAB (android:id="@+id/fab_commons_page") in nearby, I don't know if it is even in use or not.

[domdomegg]

It doesn't seem to be used anywhere - probably worth removing or changing the padding settings as formatting looks weird with the extra gap there.

[madhurgupta10]

@domdomegg Could you please review #2787 in high priority, due to the crash I am unable to test other UI changes. EDIT: PR Merged

[madhurgupta10]

It doesn't seem to be used anywhere - probably worth removing or changing the padding settings as formatting looks weird with the extra gap there.

@domdomegg Even removing it, didn't helped, to fix that small gap, I probably have to go through many changes, not in UI but also in NearbyMapFragment, Also opening it horizontally in Landscape mode This might take a long time to do so, better to do it in a separate PR IMO. EDIT: Fixed, See Screenshot Below

[madhurgupta10]

@domdomegg Done :)

Side by Side Comparison (the new padding is similar to one present in Contributions Fragment)

[madhurgupta10]

@neslihanturan @domdomegg please review the new changes :)

[neslihanturan]

Worked fine for me, thanks @madhurgupta10