Skip to content

Codecov reports for PRs? #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misaochan opened this issue Mar 29, 2019 · 4 comments
Closed

Codecov reports for PRs? #2805

misaochan opened this issue Mar 29, 2019 · 4 comments

Comments

@misaochan
Copy link
Member

misaochan commented Mar 29, 2019

Some time ago (I can't remember how long, probably a year or so?) we used to have Codecov reports for every PR that was submitted. In the pull request itself, Codecov would mention how merging the PR would affect test coverage.

Somewhere along the way, we lost that. Does anyone know why, and how we can get these reports activated again? @whym @domdomegg @psh @maskaravivek

@misaochan
Copy link
Member Author

Edit: Oh, I just realized that some PRs have them, but some don't. For instance, #2798 does not have them, but #2792 does. It does appear that the majority of PRs have them, although the report will be posted at a variable time.

@maskaravivek
Copy link
Member

Yes, I have observed that sometimes the report takes a lot of time to get generated.

@domdomegg
Copy link
Member

It is bizarre that it does take so long with some PRs (like #2798). Maybe it's worth raising a bug upstream with Codecov? I've found a trick to force it to review it again is to redo the Travis build. This seems to me maybe like some webhook getting lost on its way from either Travis or Github to Codecov.

@madhurgupta10
Copy link
Collaborator

This issue is fixed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants