Skip to content

Fix #2793: Campaigns work on Beta #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Fix #2793: Campaigns work on Beta #2798

merged 2 commits into from
Mar 30, 2019

Conversation

domdomegg
Copy link
Member

Description (required)

Fixes #2793: Beta Campaigns

What changes did you make and why?

  • Pulled the Wikimedia campaigns URL into the build config
  • Created endpoint in campaigns repo

Requires commons-app/campaigns#5 to be merged before this.

Tests performed (required)

Tested 2.10.1-debug-beta-campaigns~031f334c0 using domdomegg fork.

@misaochan
Copy link
Member

misaochan commented Mar 29, 2019

Thanks for the PR @domdomegg , but I'm a bit confused. Does this only affect beta, or will it affect prod as well?

(Edit: I just saw the changes at commons-app/campaigns#5 , which explains my confusion - let's carry on the discussion there. :) )

@domdomegg domdomegg changed the title Fix #2793: Campaigns work on Beta [WIP Fix #2793: Campaigns work on Beta Mar 29, 2019
@domdomegg domdomegg changed the title [WIP Fix #2793: Campaigns work on Beta [WIP] Fix #2793: Campaigns work on Beta Mar 29, 2019
@codecov-io
Copy link

Codecov Report

Merging #2798 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2798      +/-   ##
=========================================
+ Coverage    3.83%   3.84%   +<.01%     
=========================================
  Files         267     267              
  Lines       12529   12522       -7     
  Branches     1083    1082       -1     
=========================================
  Hits          481     481              
+ Misses      12015   12008       -7     
  Partials       33      33
Impacted Files Coverage Δ
.../java/fr/free/nrw/commons/di/NetworkingModule.java 0% <ø> (ø) ⬆️
...ee/nrw/commons/media/MediaDetailPagerFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031f334...ff4718d. Read the comment docs.

@domdomegg domdomegg changed the title [WIP] Fix #2793: Campaigns work on Beta Fix #2793: Campaigns work on Beta Mar 29, 2019
@misaochan misaochan merged commit 69b0f40 into commons-app:master Mar 30, 2019
@domdomegg domdomegg deleted the beta-campaigns branch March 30, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants