Suggested fixes for "showcase view whole nearby activity"

[amire80]

Summary:

A couple of things should be fixed for the benefit of the users and the translators.

Steps to reproduce:

Check the messages "showcase view whole nearby activity" and "search this area".

The message "showcase view whole nearby activity" currently says: "Clicking on 'SEARCH THIS AREA' locks the map and launches a nearby search around that location."

The words "SEARCH THIS AREA" in the message above probably refer to the message with the key "search this area", the text of which is "Search this area" - not in all-caps. Several things to fix in the messages' text:

• The capitalization must be consistent.
• Don't use all-caps for any kind of emphasis or design that must be translatable because most alphabets don't have lowercase and uppercase distinction.

Furthermore, perhaps the message "showcase view whole nearby activity" can automatically include the text of the other message, so that the consistency would be enforced and translators wouldn't have to copy things.

[fredrikjonasson]

I would like to start my contribution with this one.

[fredrikjonasson]

I took a quick look and it seems to be consistent capitalization towards the user. The key "Search this area" indeed seems to refer to the text as you describe. Should it be changed anyway to be consistent towards the developer?

[HarunJr]

Hello @amire80, I'd like to contribute to this issue.

[amire80]

Go for it. I just reported the bug, I'm usually not a developer on this project. It's probably not very difficult. Thank you!

[HarunJr]

Let me get it right @amire80,
First, remove capitalisation in strings.xml where it's written Clicking on 'SEARCH THIS AREA'
Then automatically reference the value 'Search this area' from both the key showcase_view_whole_nearby_activity and search_this_area.
is that correct?

[amire80]

Yes. The capitalization should be consistent. My suggestion is not to use ALL CAPS, but to write "Search this area", because there are many languages in which ALL CAPS are irrelevant, such as Chinese, Hindi, and Arabic. However, maybe the designer of the app has a different opinion about this. The important thing is that it will be consistent.

And if you can automatically insert "Search this area" into "Clicking on 'SEARCH THIS AREA'" as a parameter, then the capitalization will become consistent automatically. (By "parameter" I mean something like %1$s.)

[neslihanturan]

Hi @HarunJr , thanks for your interest but currently related classes are being edited. So what about waiting until #2969 is merged and after that if the issue still persist you can solve.

[HarunJr]

No problem @neslihanturan. I shall wait.

[FawziyahAlebiosu]

Looks to me like inside of the strings.xml file, search this area has been removed and is no longer capitalized. See here:

apps-android-commons/app/src/main/res/values/strings.xml

Line 452 in 0ad269d

<string name="search_this_area">Search this area</string>

Can this issue be closed now?

[FawziyahAlebiosu]

I spoke too soon!
@HarunJr looks like all that is left is for this line to be made to lowercase and then both strings will be consistent:

apps-android-commons/app/src/main/res/values/strings.xml

Line 310 in 0ad269d

<string name="showcase_view_whole_nearby_activity">These are the places near you that need pictures to illustrate their Wikipedia articles.\n\nClicking on \'SEARCH THIS AREA\' locks the map and launches a nearby search around that location.</string>

[macgills]

Buttons in android by default capitalise all the text that you set to them so I doubt SEARCH THIS AREA was ever in the codebase as all caps. I am not 100% on what to do here because referencing our button SEARCH THIS AREA with the non capitalised text Search this Area weakens their connection in English.

I'd say the best way it to probably paramterise showcase_view_whole_nearby_activity and Uppercase search_this_area as works by locale.

@neslihanturan any opinions on how this should look?