Skip to content

Contributions DAO saves invalid image URLs #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maskaravivek opened this issue Apr 20, 2019 · 1 comment · Fixed by #2901
Closed

Contributions DAO saves invalid image URLs #2899

maskaravivek opened this issue Apr 20, 2019 · 1 comment · Fixed by #2901
Assignees
@maskaravivek

Comments

@maskaravivek
Copy link
Member

maskaravivek commented Apr 20, 2019 •
edited
Loading

Summary:

The image URL saved in contributions DB isn' valid for the ones I checked. So there's some issue in the logic that saves the image Url. We need to fix this to take advantage of caching.

Eg.

https://upload.wikimedia.org/wikipedia/commons/0/04/File%3AClownfish_in_Two_Oceans_Aquarium%2C_Capetown-_-_6.jpg

--

Steps to reproduce:

  • Take a debuggable build
  • Go to chrome://inspect
  • Go to Resources tab
  • Go to commons.db > contributions
  • Check image url

Commons app version:

Latest master

Screen-shots:

Screen Shot 2019-04-20 at 11 51 10 AM

Would you like to work on the issue?

Yes
@maskaravivek
Copy link
Member Author

This could be the reason behind a couple of bugs in the app:

@maskaravivek maskaravivek self-assigned this Apr 20, 2019
@maskaravivek maskaravivek mentioned this issue Apr 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maskaravivek maskaravivek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not use erroneous thumb url util function maskaravivek/apps-android-commons
1 participant
@maskaravivek