-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Do not use erroneous thumb url util function #2901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use erroneous thumb url util function #2901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2901 +/- ##
=========================================
- Coverage 3.42% 3.39% -0.04%
=========================================
Files 246 246
Lines 12252 12212 -40
Branches 1080 1080
=========================================
- Hits 420 414 -6
+ Misses 11802 11768 -34
Partials 30 30
Continue to review full report at Codecov.
|
1a95d9d
to
73dff40
Compare
reviewController.onImageRefreshed(fileName); //file name is updated | ||
compositeDisposable.add(reviewHelper.getFirstRevisionOfFile("File:" + fileName) | ||
compositeDisposable.add(reviewHelper.getFirstRevisionOfFile(fileName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is beyond the scope of this PR, but can you clear the composite disposable in the onStop/ onDestroy of the activity, ?
Thanks for merging @ashishkumar468 |
Description (required)
Fixes #2899
Fixes #2900