Skip to content

Optimize peer review, avoid unnecessary calls #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neslihanturan opened this issue Apr 24, 2019 · 0 comments · Fixed by #2937
Closed

Optimize peer review, avoid unnecessary calls #2921

neslihanturan opened this issue Apr 24, 2019 · 0 comments · Fixed by #2937
Labels
code-quality

Comments

@neslihanturan
Copy link
Collaborator

Summary:
As described here: #1544 Review needs some performance optimization. @maskaravivek seems familiar with the new implementation in ReviewHelper.java.

Note: Please only see the last commit from the closed PR.
@maskaravivek maskaravivek changed the title Optimize peer review, acoid unnecesary calls Optimize peer review, avoid unnecessary calls Apr 25, 2019
@maskaravivek maskaravivek mentioned this issue Jun 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use data client for peer review calls maskaravivek/apps-android-commons
1 participant
@neslihanturan