[WIP] Review: don't dump whole RC list when first nominated for delete #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First draft of fn to get random recent image * Use log entries for requests to beta, try to connect refresh button FIXME: runs http request on main thread, breaks * Tweak button connection
* tiny fixes * Load pictures into activities
And try to add pager indicator
… wikimedia-hackathon-2018
* Use standalone category extraction code in MediaDataExtractor * Add categories to category review page
…-app/apps-android-commons into wikimedia-hackathon-2018
…-app/apps-android-commons into wikimedia-hackathon-2018
…-app/apps-android-commons into wikimedia-hackathon-2018
time-based randomness is biased - if someone uploaded 100 images in hour, one week ago, and I select a random point in time, their last image is way more likely to come up than anything else. With this, there is still bias towards choosing one of the last N in any burst of uploads (where N is the number of recent changes fetched) but it's a bit better than before.
…-app/apps-android-commons into wikimedia-hackathon-2018
… wikimedia-hackathon-2018
… wikimedia-hackathon-2018
Instead of looking for a whole new 10 recent changes, keep looking through the same image list when one is nominated for deletion.
Codecov Report
@@ Coverage Diff @@
## wikimedia-hackathon-2018 #1544 +/- ##
===========================================================
- Coverage 2.97% 2.97% -0.01%
===========================================================
Files 146 146
Lines 7819 7823 +4
Branches 747 747
===========================================================
Hits 233 233
- Misses 7571 7575 +4
Partials 15 15
Continue to review full report at Codecov.
|
|
@ejegg Is this PR ready for review? @neslihanturan Are you aware of the state of this PR? |
12d36d5 to
3574b1d
Compare
|
Closing this issue since so many thing in the code changed since then. But the optimization here is important. I tried to combine this optimization with the current implementation, but I failed due to lack of Rxjava knowledge. So pinging @maskaravivek , just see the last commit from the commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looking for a whole new 10 recent changes, keep looking
through the same image list when one is nominated for deletion.
Description (required)
Fixes #{GitHub issue number and title}
{Describe the changes made and why they were made.}
Tests performed (required)
Tested on {API level & name of device/emulator}, with {build variant, e.g. ProdDebug}.
Screenshots showing what changed (optional)
{Only for user interface changes, otherwise remove this section. See how to take a screenshot}
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.