[GSoC 2019] Caption not filled when uploading from Nearby

[nicolas-raoul]

Steps to reproduce:

1. Go to Nearby
2. Select a pin
3. Add a picture for it
4. Problem: In the metadata activity, Caption is empty

In master, title get filled with the label of the Wikidata item.

Fix:
Fill the caption using the label of the Wikidata item (using the code already present for title, that should be an easy change, the only difficulty is to set the right language in the UI).

[vanshikaarora]

@nicolas-raoul I have started working on it. But there is just one problem. How can i detect current language in which the place is returned from NearbyFragment. Do you have any idea how to proceed?

[nicolas-raoul]

Good question!
You should modify NearbyFragment to make it give the language too.
Let's consider that classLabelPreferredLanguage is always the language of the label (even though it is not always true today: As can be seen in app/src/main/resources/queries/nearby_query.rq, the language might be any other language if there is no label filled for classLabelPreferredLanguage, but that's another issue which is out-of-scope for this GSoC).

[vanshikaarora]

@nicolas-raoul here i see:

localizationPlugin.matchMapLanguageWithDeviceDefault();

that we are trying to match with the apps language, so instead of searching in nearbyfragment, shall i use the devices locale as caption's language

[nicolas-raoul]

Yes, you can do that.
It is not ideal, but anyway we can't make that feature perfect until #2663 is implemented, so using the device's language is good enough for now.

[vanshikaarora]

OK I'll try this out

[vanshikaarora]

@nicolas-raoul I have resolved the issue here. Please check:)

[nicolas-raoul]

Unfortunately the issue is still present.

[vanshikaarora]

@nicolas-raoul this issue is fixed for me in the commit vanshikaarora@59ac109 . In case if the issue still persist for you we can try using place.label instead of place.name. Can you please check :)

[nicolas-raoul]

I just tried the latest upload_caption_depict and unfortunately the caption is not set:
https://commons.wikimedia.org/wiki/File:Shark_fins,_abalone,_birds%27_nests.jpeg

[vanshikaarora]

I'll look into the issue again:)

[nicolas-raoul]

This now works as expected, the caption is present, I tried with several languages :-)