Wrong photo displayed in ContributionsActivity during upload process [current master]

[misaochan]

Summary:

The previous photo uploaded is displayed instead of the current photo being uploaded

Steps to reproduce:

Upload a photo and watch the process in ContributionsActivity

Device and Android version:

Samsung Galaxy s9 Android 8.1

Commons app version:

Current master

Screen-shots:

[nicolas-raoul]

I confirm, it happens all the time.

[ashishkumar468]

I was trying to fix this issue, seems like the local URI which we have while uploading an image is not an actual path of the image, its the one provided by the content provider for temporarily accessing the input stream and my guess is that it does not support concurrent access(while the upload is going on the image is not loaded). The best solution I could come temporarily is to show a place holder image instead of wrong image while the upload is in progress and once the upload finishes, show the image with the url we have. What do you guys say @maskaravivek @misaochan @neslihanturan @nicolas-raoul ?

[neslihanturan]

@ashishkumar468 Place holder image seems like a good idea to me.

But what I did not understand this issue is recently happened. How come it was working previously?

[ashishkumar468]

@neslihanturan , You mean the correct image was being shown while the image was being uploaded ?

[neslihanturan]

Yes @ashishkumar468

[ashishkumar468]

Do you mean the current production app @neslihanturan , I just downloaded the app from play store, seems like even in this version, we just show a place holder image while the upload is going on and then just after the upload finishes, we show the actual image. Attaching the relevant gif file

[nicolas-raoul]

Placeholder is OK for me. It is definitely better than showing the wrong image.

[neslihanturan]

Thanks for the gif @ashishkumar468 , I was trying to say not in current master but there was a time upload preview was working. Anyway, I think everyone agrees and we go with placeholder solution.

[ashishkumar468]

I just edited my comment, I meant the current prod app live on google play store. @neslihanturan :-), I will still try to figure out if we can somehow show the actual image while upload, worst cases will show the place holder

[misaochan]

Placeholder is fine in my book as long as it updates to the correct image after the upload is complete. In fact, I am happy to release with that. :)

@neslihanturan I think it might be caused by changes that we made to the way we handle file paths in the last several months, to prevent certain crashes and failures that we were experiencing.

[neslihanturan]

I suspected the same @misaochan , but such a obvious bug would be reported on pull request tests for sure. But definitely this issue is related with those changes.