Remove SyncService and SyncAdapter

[ashishkumar468]

Summary:

The app uses SyncService and SyncAdapter which does nothing but makes the api call and saves the data in db, the same can be done from the Activity as well. The Sync service is useful only when our backend supports that(send us data letting us know that do we need to sync), or if we use periodic syncs. As currently our app uses none of them. We can simply shift to making the api call from the activity itself

[ashishkumar468]

Would be great if @misaochan @maskaravivek @neslihanturan could share your views :-)

[misaochan]

Would we not need to do periodic syncs once we implement the ability to pause/resume uploads?

[maskaravivek]

Would we not need to do periodic syncs once we implement the ability to pause/resume uploads?

Sync adapter is mostly used when you want to schedule periodic syncs in the background. Our sync adapter does nothing of that sort. It simply triggers sync when MainActivity is opened. Since we don't intend to perform background syncs SyncAdapter is just an overhead. A simple API call would be enough.

As far as pause/resume uploads or dynamic update of list is concerned, it would be taken care of by live data once we move to Room DB.

[ashishkumar468]

Also, the sync adapter as of now is meant to sync contributions and takes no part in upload. The Upload is happening from a separate service (UploadService), which will be modified along with others to support Pause/Resume.

[ilgazer]

IMO it would be better if we did away with ContributionsSyncAdapter and connected our data sources(ContributionDao for failed uploads etc. and UserClient for online data) to the RecyclerView directly. How important is caching the user's contributions offline? If we did away with offline caching of contributions, we could maybe fetch the images in the pre-upload stage from UploadService and do away with ContributionsDao as well.

[ashishkumar468]

This has already been implemented