Go through all our existing dependencies to see if we should keep or remove them

[misaochan]

Subtask of #1092

We have already implemented a stricter process for including new libraries in pull requests, and we will now go through all our existing dependencies to see if we should keep or remove them, and refactor the code accordingly.

[RozaliiaRusskikh]

Hello! As I understand we have to remove unused dependencies only?

[nicolas-raoul]

@RozaliyaRusskikh Yes, just comment each one by one and check whether it still works :-)

[RozaliiaRusskikh]

Thank you! Could I take this issue?

[nicolas-raoul]

@RozaliyaRusskikh OK!
Please post your findings here.

This is a first step before a more in-depth look at each remaining dependency to see whether some could be dropped by changing our source code a bit.

[RozaliiaRusskikh]

I have looked through existing dependencies located in build. gradle (Module: app) file to see if they should be deleted or kept. I have commented each one by one and have checked whether it still works. The next dependencies are unused:

implementation 'com.google.code.gson:gson:2.8.5'
implementation 'io.reactivex.rxjava2:rxandroid:2.1.0'
implementation 'io.reactivex.rxjava2:rxjava:2.2.3'
implementation 'com.drewnoakes:metadata-extractor:2.11.0'
implementation 'com.mapbox.mapboxsdk:mapbox-android-sdk:6.8.0'
implementation 'com.jakewharton.timber:timber:4.7.1'
implementation "com.google.dagger:dagger:$DAGGER_VERSION"

[nicolas-raoul]

Nice!
Can you please remove them and send a pull request?
I forgot: Please also test on the lowest version of Android supported by the app (you can find in the manifest and create an AVD emulator for that Android version).
Thanks! :-)

[RozaliiaRusskikh]

Could you please have a look at PR?

[nicolas-raoul]

@RozaliyaRusskikh Thanks for the PR! Review might take a bit of time since it is not a high-priority issue.
By the way, here is a high-priority issue which is beginner-friendly, feel free to take it: #3126

[misaochan]

Hi @RozaliyaRusskikh , thanks for your interest! This issue is a little more complex than just removing unused dependencies, but that is a fantastic first step. I have merged your PR.

The next step would be deciding which USED dependencies are redundant and which ones are not, but that would be part of a larger discussion.