Picture zoomed too much

[chinmoy12c]

Summary:
When a picture is clicked, the picture is zoomed to the point that parts of the picture are not visible.

Steps to reproduce:
Open any picture in featured or mobile uploads.

Device and Android version:
I'm using Redmi note 7s with android version 9(Pie)

Commons app version:
version 2.11.0

Screen-shots:

Would you like to work on the issue?
Yes, I would like to work on this issue. I have found a way to fix it by using https://github.com/ongakuer/PhotoDraweeView and i request permission to use this library.

[nicolas-raoul]

So, do you suggest showing the picture at the top and fill the rest with black?

Is there really no way to achieve that without using the PhotoDraweeView library?

[chinmoy12c]

So, do you suggest showing the picture at the top and fill the rest with black?

Is there really no way to achieve that without using the PhotoDraweeView library?

Yes, the library places the image automatically in the centre and it looks good on the black background as well.

The reason for using PhotoDraweeView library was that it was an extension to the Fresco library so it was compatible with existing code. If you want i can look for a way to achieve this without the library.

[chinmoy12c]

Found a better solution without using the library , changing the scale type to fitCenter fixed the issue.

EXTRA MODIFICATIONS
Should I make the background black as well? It looks better.

[nicolas-raoul]

Yes, black background would be great :-) Also, does it look strange when scrolling the details up a bit? A few more screenshots would be great (once the background is black). Thanks!

…

On Tue, Dec 31, 2019 at 4:54 AM Chinmoy ***@***.***> wrote: Found a better solution without using the library , changing the scale type to fitCenter fixed the issue. [image: Screenshot_2019-12-31-01-15-15-711_fr free nrw commons beta] <https://user-images.githubusercontent.com/57670338/71598148-c41dbe00-2b6b-11ea-8826-8982b5cfd4fd.jpg> *EXTRA MODIFICATIONS* Should I make the background black as well? It looks better. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3312?email_source=notifications&email_token=AAAYKBVBLYYE5CPO2T36YS3Q3JGYBA5CNFSM4KBMNPBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH3CFNY#issuecomment-569778871>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYKBQ7FI7LGTNBT4KAGZ3Q3JGYBANCNFSM4KBMNPBA> .

[chinmoy12c]

This is how it looks now.

[nicolas-raoul]

Looks like a good improvement to me! Could you please post a few screenshots in landscape mode too? 🙂

…

On Tue, 31 Dec 2019, 15:12 Chinmoy, ***@***.***> wrote: This is how it looks now. [image: Screenshot_2019-12-31-11-35-14-939_fr free nrw commons beta] <https://user-images.githubusercontent.com/57670338/71611846-59e43800-2bc2-11ea-80d5-b6afb0b8d46a.jpg> [image: Screenshot_2019-12-31-11-35-10-156_fr free nrw commons beta] <https://user-images.githubusercontent.com/57670338/71611847-59e43800-2bc2-11ea-8d90-8c17f134dfff.jpg> [image: Screenshot_2019-12-31-11-33-39-724_fr free nrw commons beta] <https://user-images.githubusercontent.com/57670338/71611848-59e43800-2bc2-11ea-9788-a4c192904cf5.jpg> [image: Screenshot_2019-12-31-11-33-35-363_fr free nrw commons beta] <https://user-images.githubusercontent.com/57670338/71611850-5a7cce80-2bc2-11ea-8439-6b78d742b026.jpg> [image: Screenshot_2019-12-31-11-33-31-079_fr free nrw commons beta] <https://user-images.githubusercontent.com/57670338/71611851-5a7cce80-2bc2-11ea-834d-cb3c11c0ddb6.jpg> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3312?email_source=notifications&email_token=AAAYKBQPYHYQ2YRTJTZ667TQ3LPDVA5CNFSM4KBMNPBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH3YY4A#issuecomment-569871472>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYKBWFASWYLSE56LWTQNTQ3LPDVANCNFSM4KBMNPBA> .

[chinmoy12c]

These are landscape view screenshots

[nicolas-raoul]

Looks great!
Could you please send a pull request and post the link to it here?
Thanks :-)

[chinmoy12c]

This is the pull request link.
#3315 (comment)
Thank You :)

[madhurgupta10]

@nicolas-raoul Was the issue closed without any PR merger?

[kbhardwaj123]

@madhurgupta10 actually I have added fix for this in my PR #3422 for handling zoom in which I have maintained the aspect ratio as requested in it's issue thread