Issue with gitignore

[ashishkumar468]

Summary:

gitignore includes not to ignore files with path
-!/.idea/codeStyles/
because of which .idea/codeStyles/Project.xml shows up in changed files

Commons app version:

Current master

Would you like to work on the issue?
Yes

[macgills]

We need to address the fundamental issue of why people are not realising that AS has changed a file or why AS is changing the file.

For people not being aware of their changes I generally recommend using a git client, sourcetree/gitkraken because the ui is a lot friendlier

As to why AS is changing it it could be that this happens only on import, or it could be that people are running different version of AS than me, I am on 3.6.1. The codestyle should not change unless a person changes it

As a last desperate measure we could just change the codestyle as I think it seems most people have problems with the c# section which obviously we don't care about

[sivaraam]

As to why AS is changing it it could be that this happens only on import, or it could be that people are running different version of AS than me, I am on 3.6.1. The codestyle should not change unless a person changes it

As we're seeing cases where AS is messing with the codeStyle itself, I think we can look into alternatives assuming it's hard to figure out why AS is modifying the file. Is there any reason not to use alternative options such as checkstyle to check for code style? I've seen the Wikipedia app use it for their project code styles. There's even another issue about integrating the spotless plug-in for the code style: #3405

[macgills]

checkstyle has poor automatic formatting support if memory serves and it is only for java so it doesn't really matter to me much.

Spotless could be okay, its general purpose-ness gives me cause for doubt. Personally haven't used it.

This should be an important lesson for new contributors to learn anyhow "Don't commit something you didn't change".

I'd rather figure out why AS is changing the file, is it happening for anyone on this issue?

[misaochan]

Yes, it happens for me on AS 3.6.1.

[macgills]

@misaochan can you commit the changes to Project.xml a branch and I can try switching to it to see what happens for me?

[misaochan]

https://github.com/misaochan/apps-android-commons/tree/Project-xml-debugging

[aryan-earth]

Happened with me as well on Android Studio 3.6.1

[macgills]

looks like I am the problem I would say https://stackoverflow.com/a/34628619 I turn off a lot of these plugins because they slow down build time

[macgills]

Who wants to open a PR to update the codestyle?

[macgills]

I'll open a PR so

[aryan-earth]

I'll open a PR so

I can take this up but I didn't respond since I am really not sure how to patch this up 😅

Edit: Now I know what was to be fixed by looking at your PR changes :)