Nearby: Copy the place name on long click

[gupta-anmol]

Summary:

In Nearby, copy the place name to clipboard on long click, instead of just a normal click.

How can we reproduce the issue?

Open Nearby. Select any location pin. Tap on the place name.

What did you expect the app to do, and what did you see instead?

Currently, a normal click also copies the text to clipboard. And it is very annoying because the toast appears whenever we expand or collapse the place information (see gif below).

It was first introduced through issue #2405. Clearly, it was always intended to be a copy on long click. However, this was changed (most probably by mistake) when these commits were made, and the code from NearbyMapFragment.java was shifted to NearbyParentFragment.java.

Screen-shots:

Would you like to work on the issue?

Yes.

[macgills]

Long click always hides a feature for me, the benefit here is if people do try to select the text by long pressing on it we get rid of the need to deal with highlighting. If we wish to surface this functionality better an explicit copy button could be used like the github icon

or the text copy itself

[nicolas-raoul]

@6point022 I agree that it is annoying now. Good enhancement idea! :-)

Since it is a very non-vital feature, I don't think we need to surface it more.
Actually the Google Maps app does not surface it either, but the place name is actually copyable via long-press.

[gupta-anmol]

@nicolas-raoul Let me know if the proposed solution (changing it to a long click) is fine and I will create a PR. :)

[nicolas-raoul]

Yes, it is fine. Thanks! :-)