Intermittent issue with user/pass not being saved when entering 2FA code

[misaochan]

I received a report of an issue from a 2FA user with v2.12.3 of the app. This problem happens occasionally for her when she tries to log in with 2FA:

1. Enter username and password
2. App prompts you for 2FA code
3. When you copy the 2FA code and come back to the app, the username and password is empty, requiring you to type them all over again while the 2FA timer is ticking

I have not managed to reproduce this personally, but if anyone can, please let us know how you managed it!

[sivaraam]

I have a hunch that this could be happening when Android kicks the app out of memory due to low memory. I'm not very sure though.

@misaochan Can you ask the device model of that user? It might be helpful. If possible, also ask them if the phone was under memory pressure (which would hopefully be apparent by noticeable lag when coming back to the app) when they faced this issue.

[macgills]

It definitely sounds like the activity was recreated and we do not persist the state but I quickly experimented with do not keep activities turned on and my uname/pass were persisted across recreation. There must be something happening with the 2FA flow? I do not have it enabled

[misaochan]

The user's response was: "I have a Samsung S7 Edge. No I did not notice any freeze or anything: what does happen is the keyboard of the Commons app stays visible."

So I don't think the device model is likely to be a problem - the S7 Edge is a slightly older model, but still well within the mid-range as far as specs go, so it should have enough memory for this purpose IMO?

[misaochan]

It definitely sounds like the activity was recreated and we do not persist the state but I quickly experimented with do not keep activities turned on and my uname/pass were persisted across recreation. There must be something happening with the 2FA flow? I do not have it enabled

I rotated my device, which resulted in the activity being recreated - the username and password are persisted for me, although the 2FA code field disappears so you have to tap "Login" again for it to come back up. But that isn't a big problem and not what the user is experiencing.