No Depictions Selected Dialog has reversed buttons

[macgills]

Summary:

The dialog buttons have the positive action in the negative position and vice versa

Commons app version:

structuredData

[sivaraam]

One comment about the "No, Go back" button in the dialog. It's possible for someone to read the "Go back" (if they don't read the description) and wonder if this would take them to the previous step. I believe "Submit" and "Cancel" would be a concise pair of words that would avoid this confusion.

Also, a more general doubt. Do we really show a dialog whenever a user does not choose any depictions? Wouldn't that be intrusive? Depictions are a good to have. Can't we convey that in a more subtle way than prompting them each time via a dialog?

[macgills]

@sivaraam this issue is now merged and I am going to close it, please open a new ticket for discussion on the text/functionality

[sivaraam]

Ok. I've created #3675 for this.