Nearby Tab Accessible Without Location Permission

[nathanmeade]

Summary:
When the user has not granted permission for location, the nearby tab can still be accessed when performing the appropriate steps - displaying the nearby tab and map without any results. To prevent the displaying of the nearby tab without any results in this case, the edge cases that allow for the user selecting the nearby tab without the location permission (no location data) need to be fixed.

This issue was discovered when attempting to reproduce the blank nearby list issue (#3727) @neslihanturan

Steps to reproduce:

1. Make sure the app does not have the location permission
2. While logged in, select the "Nearby" tab of the "Home" screen
3. Deny the access to location
4. Select "No" to the permission request dialog
5. Select the "Nearby" tab again
6. Tap away from the dialog to make it disappear
7. Observe that there are no results

Screen-shots:
No results map screenshot:

No results list screenshot:

Would you like to work on the issue?

I would like to work on this issue.

[neslihanturan]

Yes @nathanmeade , you understood the issue right. User should never see this empty map at all.

[gerardolgvr]

Hello! Is this fixed?

I was thinking about some possible solutions to this problem:

• Add an extra message telling the reason why is location permission important (using shouldShowRequestPermissionRationale). I found this useful information (https://stackoverflow.com/questions/30719047/android-m-check-runtime-permission-how-to-determine-if-the-user-checked-nev)
• If the user doesn't grant permission we can replace the map fragment with another fragment and inside place a button to have quick access to grant the permission for location.

Let me know your thoughts, have a nice day

[neslihanturan]

Thank you for suggestions @gerardolgvr , the issue is still not fixed. You can work on this one. I think ideal solution is sending the user back to contributons fragment when permission is not given.

[gerardolgvr]

oh yeah, sounds a great idea @neslihanturan

Thanks

[nathanmeade]

@neslihanturan @gerardolgvr I have not been able to get to this fix yet. Feel free to reassign this as you see fit.

[Anyrob]

Hi! I would like to take it if you don't mind, I already have thought a solution, just waiting for you, to give me green light :) @neslihanturan @gerardolgvr

[neslihanturan]

Please go for it @Anyrob :)

[neslihanturan]

Thank you @nathanmeade for your time and reporting your unavailabilit :)

[Anyrob]

Thank you!! @neslihanturan

[gerardolgvr]

Go ahead @Anyrob ! :D

[Anyrob]

Hi, @neslihanturan! I was wondering if you have had a chance to check my pull request. This time, I was trying to add some test but I ran into a lot of problems since other tests are broken even though I try different ways (even with espresso which also helped me discover another bug in the application) I did not find a way to perform the test in any way other than manual, do you have any recommendations for me?