Skip to content

Location mismatch problem for p18 edits via Nearby uploads #3856

@misaochan

Description

@misaochan

As mentioned at #3838 (comment) , there is a problem with p18 edits via Nearby uploads in master.

@misaochan says:

I uploaded https://commons.wikimedia.org/wiki/File:Tea_Tree_Bay_3.jpg , which is for the Wikidata item https://www.wikidata.org/wiki/Q21952057 . However, the Wikidata item is not being edited at all, which leads to the Media legend not being edited at all. The reason given is fr.free.nrw.commons D/WikidataEditService: Image location and nearby place location mismatched, so Wikidata item won't be edited, but this is not a test picture, it is a real picture taken at the exact location, and you can see that the coordinates are very close.

It seems like somewhere we got our Wikidata location checks crossed, and now legitimate uploads from coordinates which should be accepted, are declined entirely. Will need to find out when the problem happened.

@maskaravivek says:

I tried debugging the location mismatch issue but couldn't figure out the issue. Something is definitely broken. I was able to reproduce the issue where I was using an image with the correct location but somehow it wasn't making the P18 and P2096 edits. Moreover, weirdly sometimes I was getting duplicate image warning even though I was taking a fresh image using the camera. I checked that the ImageUtils:checkImageGeolocationIsDifferent is getting the correct location coordinates and it is calculating the difference correctly but something breaks after this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions