Skip to content

Limited connection mode switch needs a label #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jidanni opened this issue Oct 25, 2020 · 6 comments · Fixed by #4240
Closed

Limited connection mode switch needs a label #3986

jidanni opened this issue Oct 25, 2020 · 6 comments · Fixed by #4240

Comments

@jidanni
Copy link
Contributor

jidanni commented Oct 25, 2020

Limited connection mode switch needs a label. Yes, I know there's no way to put a label there. However I challenge you to figure out what this switch is for without forcing yourself to toggle it to find out. What if there was a fire alarm button and nobody could figure out what the purpose of it was without having to push it to find out?
Version 811.

@misaochan
Copy link
Member

misaochan commented Oct 26, 2020

If you can see the limited connection mode, you must be testing master/alpha, not a release build. Yes, it needs a label, and it will have one. The UI in master is still in progress, see #2843 . :)

@jidanni
Copy link
Contributor Author

jidanni commented Oct 26, 2020

If you can see the limited connection mode, you must be testing master/alpha, not a release build.

(Yes. I hope I am still filing these in the right place here on GitHub.)

@nicolas-raoul
Copy link
Member

#2843 has been closed 4 days ago, so I think it is now fair to report any big problem :-)
Yes, this GitHub issue tracker is the right place for alpha too, but let's keep in mind that alpha is a work in progress ;-)

@jidanni
Copy link
Contributor Author

jidanni commented Nov 12, 2020

OK I will try to get used to the "cloud".

@jidanni jidanni closed this as completed Nov 12, 2020
@sivaraam
Copy link
Member

You'll see an actual label (briefly) for the switch when long pressing it. There is still one thing that could be improved about it, though. Currently it says "Limited Connection" which feels blunt to me. So, we could re-phrase it a little. I would suggest using "Limited connection mode".

@sivaraam sivaraam reopened this Nov 13, 2020
@misaochan
Copy link
Member

I'm good with changing the text to "Limited connection mode".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants