Skip to content

Changed label of Limited Connection switch #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

mrudultora
Copy link
Contributor

Description (required)

Fixes #3986 (see #3986 (comment))

What changes did you make and why?
Changed string label to "Limited Connection Mode" as suggested in the issue thread.

Tests performed (required)

Tested {build variant-betaDebug} on {Redmi Note 7S} with API level {API 29}.

@codecov-io
Copy link

Codecov Report

Merging #4240 (8a00925) into master (7cb5ff9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4240      +/-   ##
============================================
- Coverage     10.44%   10.42%   -0.02%     
  Complexity      473      473              
============================================
  Files           343      343              
  Lines         13002    13024      +22     
  Branches       1030     1038       +8     
============================================
  Hits           1358     1358              
- Misses        11576    11598      +22     
  Partials         68       68              
Impacted Files Coverage Δ Complexity Δ
...e/nrw/commons/location/LocationServiceManager.java 7.07% <0.00%> (-1.35%) 0.00% <0.00%> (ø%)
...commons/nearby/fragments/NearbyParentFragment.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb5ff9...8a00925. Read the comment docs.

@nicolas-raoul
Copy link
Member

Hi Mrudultora,
This issue is not marked as "bug".
Citing https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers :

If you are a new contributor, please only ask to be assigned to issues with a "bug" or "good first issue" label. Issues labeled "enhancement" will usually only be assigned to contributors with more than 5 merged pull requests to this repo.

How many bugs have you fixed so far?
Cheers! :-)

@mrudultora
Copy link
Contributor Author

Sorry @nicolas-raoul . I was not familiar with this part. I have opened PR for 4 issues till now. I will remember this from next time. Sorry !

@nicolas-raoul
Copy link
Member

No problem! When you have 5 bugfixes merged, please reopen this :-) Thanks!

@mrudultora
Copy link
Contributor Author

@nicolas-raoul Can this be reopened now ?

@nicolas-raoul
Copy link
Member

Congratulations on your 5 merged bugfixes!
Yes thanks :-)

@nicolas-raoul nicolas-raoul reopened this Mar 3, 2021
@nicolas-raoul nicolas-raoul merged commit 9b91eb9 into commons-app:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limited connection mode switch needs a label
3 participants